From: "H. Peter Anvin" <hpa@zytor.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org,
"Martin Langhoff (CatalystIT)" <martin@catalyst.net.nz>
Subject: Re: [PATCH] git-fetch --tags: deal with tags with spaces in them.
Date: Wed, 12 Oct 2005 08:47:12 -0700 [thread overview]
Message-ID: <434D3000.5020601@zytor.com> (raw)
In-Reply-To: <434D2D8F.2020407@zytor.com>
H. Peter Anvin wrote:
>
> We can disallow whitespace, and we *have* to disallow at least newline
> due to the file format; I believe we should disallow all control
> characters (0-31, 127-159.)
>
Actually, disallowing anything 128 and above means knowing the encoding
system. If we enforce UTF-8, we should presumably disallow at the very
least U+FFFE and U+FFFF too.
C99 contains a list of Unicode characters allowed in C identifiers. I
believe we should allow those characters (plus at a minimum -+.#:@) as
well, but I'd much rather we didn't make those kinds of decisions for
the user. If we have *specific* characters we can't tolerate we should
rule them out (like control characters), but even that occationally
leads to major frustration on the part of the user: "why can't I use '.'
in tag names in CVS"?
-hpa
next prev parent reply other threads:[~2005-10-12 15:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46a038f90510062014l7f5740e0l77fc53b50f822e8f@mail.gmail.com>
[not found] ` <46a038f90510082014i6b296f2bvbac56e25344cbdf2@mail.gmail.com>
2005-10-10 4:26 ` Strangely broken git repo Martin Langhoff (CatalystIT)
2005-10-10 9:00 ` Junio C Hamano
2005-10-10 14:54 ` Linus Torvalds
2005-10-10 15:21 ` Linus Torvalds
2005-10-10 18:19 ` Morten Welinder
2005-10-10 18:23 ` Linus Torvalds
2005-10-10 18:30 ` Johannes Schindelin
2005-10-11 4:29 ` Quote reference names while fetching with curl Junio C Hamano
2005-10-11 5:07 ` [PATCH] git-fetch --tags: deal with tags with spaces in them Junio C Hamano
2005-10-11 6:04 ` Junio C Hamano
2005-10-12 5:29 ` Junio C Hamano
2005-10-12 8:26 ` Petr Baudis
2005-10-12 15:36 ` H. Peter Anvin
2005-10-12 15:47 ` H. Peter Anvin [this message]
2005-10-12 18:57 ` Junio C Hamano
2005-10-12 18:10 ` Junio C Hamano
2005-10-12 22:01 ` [PATCH] git-check-ref-format: reject funny ref names Junio C Hamano
2005-10-12 22:01 ` [PATCH] Refuse to create funny refs in clone-pack, git-fetch and receive-pack Junio C Hamano
2005-10-11 19:55 ` [PATCH] git-fetch --tags: deal with tags with spaces in them Matthias Urlichs
2005-10-12 3:26 ` Strangely broken git repo Nick Hengeveld
2005-10-12 4:22 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434D3000.5020601@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=martin@catalyst.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.