All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>,
	Morten Welinder <mwelinder@gmail.com>,
	git@vger.kernel.org
Subject: Re: Usage of isspace and friends
Date: Thu, 13 Oct 2005 09:07:44 -0700	[thread overview]
Message-ID: <434E8650.7060604@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0510130847190.15297@g5.osdl.org>

Linus Torvalds wrote:
> 
> Yeah, and I agree, that was a mistake. It could have been fixed by making 
> EOF be MIN_INT (or any other value outside the range of either "unsigned 
> char" or "signed char" - preferably still negative), but there are 
> probably programs that depend on it being -1. 
> 
> The stupid thing I just posted doesn't care. It happens to return 0 for 
> EOF for all cases, but that's a side effect of (a) not doing locales (so 
> 255 is never printable or alpha) and (b) not even implementing iscntrl().
> 

Given that for isprint() et al are useless for non-ASCII UTF-8 anyway, 
might as well (they are not defined to be able to take wide character 
values.)

	-hpa

  reply	other threads:[~2005-10-13 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-12  1:40 Usage of isspace and friends Morten Welinder
2005-10-13  6:49 ` Junio C Hamano
2005-10-13  8:29   ` Antti-Juhani Kaijanaho
2005-10-13 13:27   ` H. Peter Anvin
2005-10-13 15:44     ` Junio C Hamano
2005-10-13 15:04   ` Linus Torvalds
2005-10-13 15:45     ` H. Peter Anvin
2005-10-13 15:56       ` Linus Torvalds
2005-10-13 16:07         ` H. Peter Anvin [this message]
2005-10-13 15:46     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=434E8650.7060604@zytor.com \
    --to=hpa@zytor.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=mwelinder@gmail.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.