From: Peter Staubach <staubach@redhat.com>
To: NeilBrown <neilb@cse.unsw.edu.au>
Cc: Andrew Morton <akpm@osdl.org>, nfs@lists.sourceforge.net
Subject: Re: [PATCH kNFSd 001 of 4] fix setattr-on-symlink error return
Date: Fri, 14 Oct 2005 08:29:56 -0400 [thread overview]
Message-ID: <434FA4C4.6010806@redhat.com> (raw)
In-Reply-To: <1051014022307.11542@cse.unsw.edu.au>
NeilBrown wrote:
>This is a somewhat cosmetic fix to keep the SpecFS validation test
>from complaining.
>SpecFS want's to try chmod on symlinks, and ext3 and reiser (at least)
>return ENOTSUPP.
>Probably both sides are being silly, but it is easiest to simply make
>it a non-issue and filter out chmod requests on symlinks at the nfsd level.
>
Wouldn't it be better to fix the testsuite to not do this? Doesn't the
testsuite also fail when run against ext3 and/or reiser file systems?
This is just overhead which will slow the NFS server a tiny bit.
Just out of curiosity, how does the testsuite even generate a chmod(2)
request on a symbolic link? The chmod(2) system call semantics should
not allow this.
Thanx...
ps
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2005-10-14 12:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 2:23 [PATCH kNFSd 000 of 4] Introduction NeilBrown
2005-10-14 2:23 ` [PATCH kNFSd 001 of 4] fix setattr-on-symlink error return NeilBrown
2005-10-14 12:29 ` Peter Staubach [this message]
2005-10-14 18:41 ` James Yarbrough
2005-10-14 19:35 ` Peter Staubach
2005-10-14 19:42 ` James Yarbrough
2005-10-14 19:46 ` Peter Staubach
2005-10-14 19:54 ` James Yarbrough
2005-10-14 2:23 ` [PATCH kNFSd 002 of 4] Restore functionality to read from file in /proc/fs/nfsd/ NeilBrown
2005-10-14 2:23 ` [PATCH kNFSd 003 of 4] Allow run-time selection of NFS versions to export NeilBrown
2005-10-14 2:23 ` [PATCH kNFSd 004 of 4] Fix some minor sign problems in nfsd/xdr NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=434FA4C4.6010806@redhat.com \
--to=staubach@redhat.com \
--cc=akpm@osdl.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.