From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Duffy Subject: Re: [PATCH] network-bridge script support for multipleexternal interfaces Date: Fri, 14 Oct 2005 11:18:33 -0500 Message-ID: <434FDA59.8000208@spamcop.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Pratt Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Ian Pratt wrote: > I'd settle for being able to specify: > > (network-script "network-bridge netdev=eth0 bridge=xenbr0 > virtnum=0","network-bridge netdev=eth1 bridge=xenbr1 virtnum=1") Thus far I haven't done any messing with xend's code, and am not entirely sure I want to. This patch was intended *only* to include an updated helper, such that xend could later be extended by someone else to actually call that helper multiple times. Personally, to call the helper more than once, I've just written some new init scripts. I'm willing to consider poking at xend, but *only* if someone who actually owns it says "okay, I'll merge a patch that does that if you implement it *like so*". Even if that means I'm doing more work to do it the maintainer's way, having specs from upstream means there's a much better chance of what I'm doing actually getting merged. > [not totally convinced about the naming of virtnum. vifnum?] I agree that vifnum is better. > [What's the correct sxp syntax for specifying a list of strings?] If they're being adequately lispy and my memory doesn't deceive me, the strings are just separated by spaces... as in (foo "bar" "baz" "qux") , '("foo" "bar" "baz") , or such.