From: Pablo Neira <pablo@netfilter.org>
To: Pablo Neira <pablo@netfilter.org>
Cc: Harald Welte <laforge@netfilter.org>,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] libnfnetlink updates
Date: Mon, 17 Oct 2005 00:11:27 +0200 [thread overview]
Message-ID: <4352D00F.9080900@netfilter.org> (raw)
In-Reply-To: <4352C36E.109@netfilter.org>
Pablo Neira wrote:
> @@ -110,10 +115,11 @@
> extern int nfnl_nfa_addattr32(struct nfattr *, int, int, u_int32_t);
> extern int nfnl_parse_attr(struct nfattr **, int, struct nfattr *, int);
> #define nfnl_parse_nested(tb, max, nfa) \
> - nfnl_parse_attr((tb), (max), NFA_DATA((nfa)), NFA_PAYLOAD((nfa)))
> +({ memset(tb, 0, max *sizeof(struct nfattr *)); \
> + nfnl_parse_attr((tb), (max), NFA_DATA((nfa)), NFA_PAYLOAD((nfa))); })
Hm, this is bogus. I just realized that the tb array is zeroed from
nfattr_parse_attr. Ignore this patch. I'll send you another patch
without this modification tomorrow.
--
Pablo
prev parent reply other threads:[~2005-10-16 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-16 21:17 [PATCH] libnfnetlink updates Pablo Neira
2005-10-16 22:11 ` Pablo Neira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4352D00F.9080900@netfilter.org \
--to=pablo@netfilter.org \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.