From: Jiri Slaby <jirislaby@gmail.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <xslaby@fi.muni.cz>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCHv3 6/6] char, isicom: More whitespaces and coding style
Date: Mon, 17 Oct 2005 12:01:10 +0200 [thread overview]
Message-ID: <43537666.9030007@gmail.com> (raw)
In-Reply-To: <200510170117.21429.dtor_core@ameritech.net>
Dmitry Torokhov napsal(a):
> On Sunday 16 October 2005 17:27, Jiri Slaby wrote:
>
>
>>+ wrd |= (port->xmit_buf[port->xmit_tail]
>>+ << 8);
>
>
>>+ pr_dbg("interrupt: DCD->low.\n"
>>+ );
>
>
>>+ port->xmit_head = (port->xmit_head + cnt) & (SERIAL_XMIT_SIZE
>>+ - 1);
>
>
> You must be kidding...
No :(. The last could be better, but that two, I don't know, how to write
better. What do you think? [Consider, it won't be applied with more than 80
columns, IMHO]
regards,
--
Jiri Slaby www.fi.muni.cz/~xslaby
\_.-^-._ jirislaby@gmail.com _.-^-._/
B67499670407CE62ACC8 22A032CC55C339D47A7E
next prev parent reply other threads:[~2005-10-17 10:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-16 22:24 [PATCHv3 0/6] isicom char driver rewritten to 2.6 api Jiri Slaby
2005-10-16 22:26 ` [PATCHv3 2/6] char, isicom: Type conversion and variables deletion Jiri Slaby
2005-10-16 22:27 ` [PATCHv3 3/6] char, isicom: Other little changes Jiri Slaby
2005-10-16 22:27 ` [PATCHv3 4/6] char, isicom: Pci probing added Jiri Slaby
2005-10-16 22:27 ` [PATCHv3 5/6] char, isicom: Firmware loading Jiri Slaby
2005-10-16 22:27 ` [PATCHv3 6/6] char, isicom: More whitespaces and coding style Jiri Slaby
2005-10-17 6:17 ` Dmitry Torokhov
2005-10-17 10:01 ` Jiri Slaby [this message]
2005-10-16 22:31 ` [PATCHv3 0/6] isicom char driver rewritten to 2.6 api Jiri Slaby
2005-10-16 22:31 ` [PATCHv3 1/6] char, isicom: Whitespace cleanup Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43537666.9030007@gmail.com \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=xslaby@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.