From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] i40e:Fix the Descriptor Done check mechanism for i40e Date: Fri, 10 Jul 2015 18:56:33 +0200 Message-ID: <4354156.5trOTC7DZb@xps13> References: <1436347759-31915-1-git-send-email-zhe.tao@intel.com> <1436410688-663-1-git-send-email-zhe.tao@intel.com> <9BB6961774997848B5B42BEC655768F8C6473D@SHSMSX104.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Tao, Zhe" Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by dpdk.org (Postfix) with ESMTP id 0D1D7C3A0 for ; Fri, 10 Jul 2015 18:57:42 +0200 (CEST) Received: by wiwl6 with SMTP id l6so51828540wiw.0 for ; Fri, 10 Jul 2015 09:57:41 -0700 (PDT) In-Reply-To: <9BB6961774997848B5B42BEC655768F8C6473D@SHSMSX104.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > If a descriptor the device drive is handling is the context descriptor, its type > > value will be 0x1. > > When using the not operator ! to do the conditional check, if the expression > > value is zero, the device driver will consider the transaction for this descriptor > > has been completed, even its DD field is still 0x1 which means NIC has not > > finished the operation on this descriptor. > > Use the 0xF to check the DD status to avoid the above issue happens. > > > > Signed-off-by: Zhe Tao > Acked-by: Jingjing Wu Applied, thanks