From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org,
Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>,
reshma.pattan@intel.com, rmody@marvell.com, shshaikh@marvell.com,
beilei.xing@intel.com, qi.z.zhang@intel.com,
alejandro.lucero@netronome.com, pablo.de.lara.guarch@intel.com,
declan.doherty@intel.com, stable@dpdk.org
Subject: Re: [PATCH] drivers: fix to replace strcat with strncat
Date: Tue, 15 Jan 2019 02:53:28 +0100 [thread overview]
Message-ID: <4355742.ZHn0J28zhk@xps> (raw)
In-Reply-To: <20190114142133.GA16996@bricha3-MOBL.ger.corp.intel.com>
14/01/2019 15:21, Bruce Richardson:
> On Mon, Jan 14, 2019 at 06:04:35AM +0000, Chaitanya Babu Talluri wrote:
> > Strcat does not check the destination length and there might be
> > chances of string overflow so insted of strcat, strncat is used.
[...]
>
> While I believe this is correct, this (and the changes below) would be a
> lot neater using strlcat function. We should perhaps look to add strlcat
> alongside strlcpy for DPDK use.
Yes it looks reasonnable.
next prev parent reply other threads:[~2019-01-15 1:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 6:04 [PATCH] drivers: fix to replace strcat with strncat Chaitanya Babu Talluri
2019-01-14 13:29 ` Ferruh Yigit
2019-01-14 16:24 ` Stephen Hemminger
2019-01-17 16:44 ` Thomas Monjalon
2019-01-14 14:21 ` Bruce Richardson
2019-01-15 1:53 ` Thomas Monjalon [this message]
2019-01-18 15:11 ` [PATCH v2] " Chaitanya Babu Talluri
2019-01-18 15:23 ` Chaitanya Babu Talluri
2019-01-21 10:43 ` Parthasarathy, JananeeX M
2019-02-07 11:56 ` Ferruh Yigit
2019-02-07 12:08 ` Thomas Monjalon
2019-02-07 13:27 ` Bruce Richardson
2019-02-13 11:54 ` Ferruh Yigit
2019-02-27 6:02 ` [PATCH v3] drivers: fix to replace strcat with strlcat Chaitanya Babu Talluri
2019-02-27 9:43 ` [dpdk-stable] " Ferruh Yigit
2019-02-27 9:49 ` Bruce Richardson
2019-02-27 10:26 ` Pattan, Reshma
2019-03-05 13:14 ` [PATCH v4] drivers: fix possible overflow with strcat Chaitanya Babu Talluri
2019-03-06 18:14 ` [dpdk-stable] " Ferruh Yigit
2019-03-07 12:56 ` [PATCH v5] " Chaitanya Babu Talluri
2019-03-13 18:39 ` Ferruh Yigit
2019-03-14 13:34 ` [PATCH v6] drivers/net: " Chaitanya Babu Talluri
2019-03-14 14:09 ` Pattan, Reshma
2019-03-18 12:41 ` [PATCH v7] drivers/net: fix possible overflow using strlcat Chaitanya Babu Talluri
2019-03-20 20:18 ` Ferruh Yigit
2019-03-22 7:51 ` [PATCH v8] " Chaitanya Babu Talluri
2019-03-22 8:02 ` [EXT] " Shahed Shaikh
2019-03-22 10:35 ` [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4355742.ZHn0J28zhk@xps \
--to=thomas@monjalon.net \
--cc=alejandro.lucero@netronome.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=reshma.pattan@intel.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
--cc=tallurix.chaitanya.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.