Re: [PATCH 7/17] atyfb: Get initial mode timings from LCD BIOS

["Antonino A. Daplas" <adaplas@gmail.com>]

Andrew Morton wrote:
> "Antonino A. Daplas" <adaplas@gmail.com> wrote:
>>  "I've tried with video=atyfb:debug and video=atyfb:debug,mode:1280x600, \
>>  nomtrr.
>>
>>  In both case, the screen stays black, but seems divided into 4 vertical
>>  bands. Some white lines pop up randomly on each vertical band."
>>
>>  The problem is a combination of an incorrect xclk plus lack of timing
>>  information.  The adapter is attached to an LCD device that can do
>>  1280x600 (which is not a standard resolution).  The global mode database
>>  does not have an entry for it.  Fortunately, the Video BIOS contains the
>>  complete timing info for this display, however, atyfb is not making use
>>  of it.
>>
>>  Add support to get the timing information from the BIOS, if available.
>>
>>  Signed-off-by: Antonino Daplas <adaplas@pol.net>
>>  ---
>>   atyfb_base.c |   58 ++++++++++++++++++++++++++++++++++++++++++++--------------
>>   1 files changed, 44 insertions(+), 14 deletions(-)
>>
>>
>>  diff --git a/drivers/video/aty/atyfb_base.c b/drivers/video/aty/atyfb_base.c
>>  --- a/drivers/video/aty/atyfb_base.c
>>  +++ b/drivers/video/aty/atyfb_base.c
>>  @@ -2156,11 +2156,38 @@ static void __init aty_calc_mem_refresh(
>>   
>>   static struct fb_info *fb_list = NULL;
>>   
>>  +#if defined(__i386__) && defined(CONFIG_FB_ATY_GENERIC_LCD)
>>  +static int __devinit atyfb_get_timings_from_lcd(struct atyfb_par *par,
>>  +						struct fb_var_screeninfo *var)
> 
> Are we sure that __i386__ is the right thing to use here?  Is it not valid
> for x86_64, for example?  Or other architecctures, come to that.
> 
> CONFIG_X86_32?
> 

This patch depends on aty_init_lcd() which is enclosed in this...

#ifdef __i386__
#ifdef CONFIG_FB_ATY_GENERIC_LCD
static void aty_init_lcd(struct atyfb_par *par, u32 bios_base)
...

...so I just follow that.


Tony


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl