From mboxrd@z Thu Jan  1 00:00:00 1970
From: Charles Duffy <cduffy@spamcop.net>
Subject: Re: Re: network-bridge script reworked
Date: Wed, 19 Oct 2005 11:03:31 -0500
Message-ID: <43566E53.7070508@spamcop.net>
References: <20051019093502.GP8705@tpkurt.tagung.uni-hamburg.de>
	<43562AC6.3030006@spamcop.net>
	<20051019115944.GB11567@tpkurt.pmc.nue.novell.com>
	<43564BFF.5050900@spamcop.net>
	<20051019155846.GR26910@leeni.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20051019155846.GR26910@leeni.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ewan Mellor <ewan@xensource.com>
Cc: xen-devel@lists.xensource.com, Kurt Garloff <garloff@suse.de>
List-Id: xen-devel@lists.xenproject.org

Ewan Mellor wrote:
> I've put in the network-bridge patch, along with Charles' changes to support
> multiple bridges.  I'm in no position to test a wide variety of
> configurations, so I would appreciate some feedback from you guys.
> 
> We currently have
> 
> pdev="p${netdev}"
> vdev="veth${vifnum}"

Since the veth* device is tied to the vif0.* device, and not to the 
physical ethernet device in the machine, the way you merged it appears 
to me to be correct. I'll try it on my test machine, though, and 
validate that it Does The Right Thing.