From: Grant Coady <gcoady@gmail.com>
To: Roland Dreier <rolandd@cisco.com>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci_ids: cleanup comments
Date: Thu, 20 Oct 2005 08:19:37 +1000 [thread overview]
Message-ID: <4356C679.2090600@gmail.com> (raw)
In-Reply-To: <524q7di40y.fsf@cisco.com>
Roland Dreier wrote:
> I don't think I like this. I prefer the format
>
> #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001 /* PCI-Cbus Bridge */
>
> to taking two lines like
>
> /* PCI-Cbus Bridge */
> #define PCI_DEVICE_ID_NEC_CBUS_1 0x0001
>
> If some script can't handle the first format then I think the script
> should be fixed.
>
> - R.
>
Fair enough, glad I'm lazy, not done the whitespace cleanup :)
How's this one?
From: Grant Coady <gcoady@gmail.com>
pci_ids.h cleanup: convert // comment to /* comment */
Signed-off-by: Grant Coady <gcoady@gmail.com>
---
pci_ids.h | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
--- linux-2.6.14-rc4-mm1a/include/linux/pci_ids.h 2005-10-17 15:14:41.000000000 +1000
+++ linux-2.6.14-rc4-mm1b/include/linux/pci_ids.h 2005-10-20 08:12:15.000000000 +1000
@@ -448,7 +448,7 @@
#define PCI_DEVICE_ID_IBM_ICOM_V2_ONE_PORT_RVX_ONE_PORT_MDM 0x0251
#define PCI_DEVICE_ID_IBM_ICOM_FOUR_PORT_MODEL 0x252
-#define PCI_VENDOR_ID_COMPEX2 0x101a // pci.ids says "AT&T GIS (NCR)"
+#define PCI_VENDOR_ID_COMPEX2 0x101a /* pci.ids says "AT&T GIS (NCR)" */
#define PCI_DEVICE_ID_COMPEX2_100VG 0x0005
#define PCI_VENDOR_ID_WD 0x101c
@@ -1161,10 +1161,10 @@
#define PCI_VENDOR_ID_INIT 0x1101
-#define PCI_VENDOR_ID_CREATIVE 0x1102 // duplicate: ECTIVA
+#define PCI_VENDOR_ID_CREATIVE 0x1102 /* duplicate: ECTIVA */
#define PCI_DEVICE_ID_CREATIVE_EMU10K1 0x0002
-#define PCI_VENDOR_ID_ECTIVA 0x1102 // duplicate: CREATIVE
+#define PCI_VENDOR_ID_ECTIVA 0x1102 /* duplicate: CREATIVE */
#define PCI_DEVICE_ID_ECTIVA_EV1938 0x8938
#define PCI_VENDOR_ID_TTI 0x1103
@@ -1174,7 +1174,7 @@
#define PCI_DEVICE_ID_TTI_HPT302 0x0006
#define PCI_DEVICE_ID_TTI_HPT371 0x0007
#define PCI_DEVICE_ID_TTI_HPT374 0x0008
-#define PCI_DEVICE_ID_TTI_HPT372N 0x0009 // apparently a 372N variant?
+#define PCI_DEVICE_ID_TTI_HPT372N 0x0009 /* apparently a 372N variant? */
#define PCI_VENDOR_ID_VIA 0x1106
#define PCI_DEVICE_ID_VIA_8763_0 0x0198
--
Thanks,
Grant.
next prev parent reply other threads:[~2005-10-19 22:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 21:27 [PATCH] pci_ids: cleanup comments Grant Coady
2005-10-19 21:35 ` Roland Dreier
2005-10-19 21:45 ` Greg KH
2005-10-19 22:19 ` Grant Coady [this message]
2005-10-19 22:27 ` Greg KH
2005-10-19 23:55 ` Grant Coady
-- strict thread matches above, loose matches on Subject: below --
2005-10-19 5:37 Grant Coady
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4356C679.2090600@gmail.com \
--to=gcoady@gmail.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.