From: Zach Brown <zach.brown@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, hch@infradead.org, adilger@clusterfs.com
Subject: Re: [RFC] page lock ordering and OCFS2
Date: Fri, 21 Oct 2005 13:32:49 -0700 [thread overview]
Message-ID: <43595071.1090906@oracle.com> (raw)
In-Reply-To: <20051021105811.2de09059.akpm@osdl.org>
>> patches/add-wake_up_page_all.patch:+EXPORT_SYMBOL(__wake_up_bit_all);
>> patches/add-wake_up_page_all.patch:+EXPORT_SYMBOL(wake_up_page_all);
>> patches/export-pagevec-helpers.patch:+EXPORT_SYMBOL_GPL(pagevec_lookup);
>> patches/export-page_waitqueue.patch:+EXPORT_SYMBOL_GPL(page_waitqueue);
>> patches/export-truncate_complete_pate.patch:+EXPORT_SYMBOL(truncate_complete_page);
>> patches/export-wake_up_page.patch:+EXPORT_SYMBOL(wake_up_page);
>
>
> Exporting page_waitqueue seems wrong. Might be better to add a core
> function to do the wait_event(*page_waitqueue(page), PageFsMisc(page)); and
> export that.
Sure thing.
> How did you come up with this mix of GPL and non-GPL?
Carelessness. I'll aim for _GPL for anything that still needs to be exported.
> The above looks sane enough. Please run it by Bill?
OK.
- z
next prev parent reply other threads:[~2005-10-21 20:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 22:20 [RFC] page lock ordering and OCFS2 Zach Brown
2005-10-17 23:17 ` Andrew Morton
2005-10-18 0:40 ` Zach Brown
2005-10-18 1:24 ` Andrew Morton
2005-10-18 8:23 ` Anton Altaparmakov
2005-10-18 17:25 ` Zach Brown
2005-10-18 17:14 ` Zach Brown
2005-10-21 17:43 ` Zach Brown
2005-10-21 17:57 ` Christoph Hellwig
2005-10-21 20:36 ` Zach Brown
2005-10-21 20:59 ` Andrew Morton
2005-10-21 21:57 ` Zach Brown
2005-10-25 0:03 ` Zach Brown
2005-10-25 16:26 ` Zach Brown
2005-10-21 17:58 ` Andrew Morton
2005-10-21 20:32 ` Zach Brown [this message]
2005-10-17 23:37 ` Badari Pulavarty
-- strict thread matches above, loose matches on Subject: below --
2005-10-12 20:13 Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43595071.1090906@oracle.com \
--to=zach.brown@oracle.com \
--cc=adilger@clusterfs.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.