All of lore.kernel.org
 help / color / mirror / Atom feed
From: adaplas@gmail.com (Antonino A. Daplas)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Re: [PATCH 2.6] i2c: Fix incorrect ID uses
Date: Sat, 22 Oct 2005 16:16:59 +0000	[thread overview]
Message-ID: <435A47E3.5070102@pol.net> (raw)
In-Reply-To: <20051022154830.0b7688ab.khali@linux-fr.org>

> --- linux-2.6.14-rc4.orig/drivers/video/i810/i810-i2c.c	2005-10-01 11:01:06.000000000 +0200
> +++ linux-2.6.14-rc4/drivers/video/i810/i810-i2c.c	2005-10-22 15:06:24.000000000 +0200
> @@ -128,8 +128,6 @@
>  	return (0 != (i810_readl(mmio, GPIOA) & SDA_VAL_IN));
>  }
>  
> -#define I2C_ALGO_DDC_I810   0x0e0000
> -#define I2C_ALGO_I2C_I810   0x0f0000
>  static int i810_setup_i2c_bus(struct i810fb_i2c_chan *chan, const char *name,
>  			      int conn)
>  {
> @@ -139,16 +137,15 @@
>          chan->adapter.owner             = THIS_MODULE;
>          chan->adapter.algo_data         = &chan->algo;
>          chan->adapter.dev.parent        = &chan->par->dev->dev;
> +	chan->adapter.id		= I2C_HW_B_I810;
>  	switch (conn) {
>  	case 1:
> -		chan->adapter.id                = I2C_ALGO_DDC_I810;
>  		chan->algo.setsda               = i810ddc_setsda;
>  		chan->algo.setscl               = i810ddc_setscl;
>  		chan->algo.getsda               = i810ddc_getsda;
>  		chan->algo.getscl               = i810ddc_getscl;
>  		break;
>  	case 2:
> -		chan->adapter.id                = I2C_ALGO_I2C_I810;
>  		chan->algo.setsda               = i810i2c_setsda;
>  		chan->algo.setscl               = i810i2c_setscl;
>  		chan->algo.getsda               = i810i2c_getsda;

Please exclude the i810-i2c chunk. I've already sent Andrew a patch
that does this and more.

Thanks.

Tony

  reply	other threads:[~2005-10-22 16:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-22 15:48 [lm-sensors] [PATCH 2.6] i2c: Fix incorrect ID uses Jean Delvare
2005-10-22 16:16 ` Antonino A. Daplas [this message]
2005-10-22 18:43 ` [lm-sensors] " Jean Delvare
2005-10-24 10:48 ` henk
2005-10-24 15:12 ` Mark McClelland
2005-10-24 16:01 ` Ladislav Michl
2005-10-24 16:39 ` Jean Delvare
2005-10-24 19:40 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=435A47E3.5070102@pol.net \
    --to=adaplas@gmail.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.