From: Pablo Neira <pablo@eurodev.net>
To: Eric Leblond <eric@inl.fr>
Cc: laforge@netfilter.org,
Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH] libnetfilter_queue naming problem
Date: Wed, 26 Oct 2005 09:58:02 +0200 [thread overview]
Message-ID: <435F370A.6040703@eurodev.net> (raw)
In-Reply-To: <1130312714.4872.57.camel@localhost.localdomain>
Hi Eric,
Eric Leblond wrote:
> I don't like the fact that it uses "struct nfattr* nfa[]" as parameter
> for high-level function because it is too much linked with the kernel
> implementation. But I do not have much time to find and propose a more
> elegant solution. Any idea ?
We can provide a higher level interface abstracted from the netlink
sockets, let me see if I can do something.
In the meantime:
> Index: include/libnetfilter_queue/libnfnetlink_queue.h
> ===================================================================
> --- include/libnetfilter_queue/libnfnetlink_queue.h (revision 4384)
> +++ include/libnetfilter_queue/libnfnetlink_queue.h (working copy)
> @@ -1,87 +0,0 @@
> -/* libnfqnetlink.h: Header file for the Netfilter Queue library.
> Index: src/libnfnetlink_queue.c
> ===================================================================
> --- src/libnfnetlink_queue.c (revision 4384)
> +++ src/libnfnetlink_queue.c (working copy)
> @@ -1,375 +0,0 @@
> -/* libnfqnetlink.c: generic library for access to nf_queue
This patch kills libnfnetlink_queue.[h|c], despite that I guess that
your intention is renaming them to libnetfilter_queue.c, correct? ;)
cheers,
Pablo
next prev parent reply other threads:[~2005-10-26 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 7:45 [PATCH] libnetfilter_queue naming problem Eric Leblond
2005-10-26 7:58 ` Pablo Neira [this message]
2005-10-26 8:02 ` Eric Leblond
2005-10-26 8:14 ` Pablo Neira
2005-10-26 11:30 ` Harald Welte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435F370A.6040703@eurodev.net \
--to=pablo@eurodev.net \
--cc=eric@inl.fr \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.