RE: [PATCH 5/6] omap4: Initialise the l3 device with the hwmod data.

[Santosh Shilimkar <santosh.shilimkar@ti.com>]

> -----Original Message-----
> From: Cousson, Benoit [mailto:b-cousson@ti.com]
> Sent: Monday, March 07, 2011 3:52 PM
> To: Shilimkar, Santosh
> Cc: linux-omap@vger.kernel.org; Balbi, Felipe; R, Sricharan
> Subject: Re: [PATCH 5/6] omap4: Initialise the l3 device with the
> hwmod data.
>
> On 2/21/2011 8:03 PM, Shilimkar, Santosh wrote:
[....]

> >> In order to stick to the OMAP device naming convention and to
> have
> >> something not dependent of the chip version, I think we'd better
> >> name
> >> the device like that: "omap_l3_noc". Since it is a Arteris
> "Network
> >> On
> >> Chip" on OMAP4. We will not have to change it for OMAP5 then.
> >> On OMAP3 the name can then be "omap_l3_smx" for the Sonics MX
> >> interconnect.
> >>
> > Device name changes are fine but file name changes as per this.
> > dosn't look right if they are like
> > omap_l3_noc.c
> > omap_l3_smx.c
>
> Why do you think that does not look right?
>
No strong preference but noc, smx didn't look ok to
me.
> > May be we can rename them like below
> > omap_l3_3xxx.c
> > omap_l3_4xxx.c
>
> The point is that it will really depend of the amount of SoC
> specifics
> data are in this file. If most of the code is reusable on OMAP5 for
> example, then it makes sense to use the name of the IP.
> If that's not the case, then you'd better use the SoC name.
>
Ok. So let's go with the IP names then.
New file names will be as above.

omap_l3_3xxx.c
omap_l3_4xxx.c

Regards,
Santosh