From: Sergei Shtylylov <sshtylyov@ru.mvista.com>
To: linux-mtd@lists.infradead.org
Cc: Konstantin Baidarov <kbaidarov@ru.mvista.com>
Subject: [PATCH] JFFS: drop kernel lock on exit from garbage collecting thread
Date: Fri, 28 Oct 2005 15:20:31 +0400 [thread overview]
Message-ID: <4362097F.5080609@ru.mvista.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 340 bytes --]
Hello.
JFFS forgets to drop a kernel lock it grabs in the garbage collecting
thread when that thread is killed by jffs_put_user(). This causes a couple of
BUG messages and a call trace to be printed out on unmounting JFFS with the
alternate spinlock implemetation which checks for the kernel lock state
consistency...
WBR, Sergei
[-- Attachment #2: JFFS-GC-drop-kernel-lock.patch --]
[-- Type: text/plain, Size: 666 bytes --]
Signed-off-by: Konstantin Baidarov <kbaidarov@ru.mvista.com>
Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Index: fs/jffs/intrep.c
===================================================================
RCS file: /home/cvs/mtd/fs/jffs/intrep.c,v
retrieving revision 1.105
diff -a -u -p -r1.105 intrep.c
--- fs/jffs/intrep.c 2 Jul 2003 20:39:55 -0000 1.105
+++ fs/jffs/intrep.c 28 Oct 2005 11:09:06 -0000
@@ -3442,6 +3442,7 @@ jffs_garbage_collect_thread(void *ptr)
case SIGKILL:
D1(printk("jffs_garbage_collect_thread(): SIGKILL received.\n"));
c->gc_task = NULL;
+ unlock_kernel();
complete_and_exit(&c->gc_thread_comp, 0);
}
}
reply other threads:[~2005-10-28 11:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4362097F.5080609@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=kbaidarov@ru.mvista.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.