Hi Harald!

Harald Welte wrote:
> I've started to write a new ulogd2 plugin against the new
> libnetfilter_conntrack, and found a number of issues, mostly related to
> header files:
> 
> 1) why do we need 'asm/types.h'?  this is unacceptable
> 2) why do we need 'linux/if.h'?

I just killed those. I'm not aware of having added those by myself, my 
guess is that they are remains of the primitive libctnetlink.

> 3) libnetfilter_conntrack needs to be split into two parts:
> 	a) what is visible to application programs
> 	b) what is visible to extensions
> 4) if we do '3', we can get rid of the ugly "linux_list.h" include

OK, now we have libnetfilter_conntrack.h and 
libnetfilter_conntrack_extensions.h, have a look at the patch below. I'm 
going to commit it asap.

> 5) we'd ideally get rid of the ip_conntrack.h include, too

I just did it, we just need the status bits. So I just took them from 
ip_conntrack.h

> 6) we should ship a copy of both nfnetlink.h and nfnetlink_conntrack.h with the library
>    this way userspace programs can be built without any
>    nfnetlink-enabled kernel headers installed.
> 
> All copies should be performed during the 'distrib' stage, i.e. every
> time we make a release we tell the automake/autoconf system where to
> take a current copy of those headers from.  They would not be present in
> svn.

OK, so we could just do it in autogen.sh, that would be quite straight 
forward. fine with it?

> 7) we put the definition of the 'nfct_handle' into a private header
>    file. this is good practise for encapsulation, since it prevents the
>    application from making any assumptions about its size and/or
>    contents.

Done

> 8) IPv6 addresses are 128bit, not 64!

Aiee, fixed as well.

I think we can release the first 1.0 version of conntrack this week, 
together with the first release of libnetfilter_conntrack. As soon as I 
finish the test for the expectation part of libnetfilter_conntrack (see 
utils) and fix some remaining problems reported on netfilter-devel. 
Then, I'll have a look back at your previous email detailing how to do 
releases, I didn't have time to do it up to now.

cheers,
Pablo