From: "H. Peter Anvin" <hpa@zytor.com>
To: Andreas Ericsson <ae@op5.se>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] Use LDFLAGS instead of ALL_CFLAGS when linking.
Date: Sat, 29 Oct 2005 09:24:03 -0700 [thread overview]
Message-ID: <4363A223.4040806@zytor.com> (raw)
In-Reply-To: <4363250C.8030200@op5.se>
Andreas Ericsson wrote:
> The patch says it all really. It lets users specify their own linking
> options and unclutters the build-output somewhat.
>
> index 5b0306d..f547d45 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -360,7 +360,7 @@ git-cherry-pick: git-revert
> $(CC) -o $*.o -c $(ALL_CFLAGS) $<
>
> git-%$X: %.o $(LIB_FILE)
> - $(CC) $(ALL_CFLAGS) -o $@ $(filter %.o,$^) $(LIBS)
> + $(CC) -o $@ $(filter %.o,$^) $(LIBS) $(LDFLAGS)
>
Typically $(LDFLAGS) comes before $(LIBS). This is not insignificant,
since some people put library seach options into LDFLAGS.
-hpa
prev parent reply other threads:[~2005-10-29 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 7:30 [PATCH] Use LDFLAGS instead of ALL_CFLAGS when linking Andreas Ericsson
2005-10-29 16:24 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4363A223.4040806@zytor.com \
--to=hpa@zytor.com \
--cc=ae@op5.se \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.