All of lore.kernel.org
 help / color / mirror / Atom feed
From: Isaac Chanin <chanin@WPI.EDU>
To: Hans Reiser <reiser@namesys.com>
Cc: Steve Olivieri <steve86@WPI.EDU>,
	reiserfs-list@namesys.com,
	Alexander Zarochentcev <zam@namesys.com>,
	vs <vs@thebsh.namesys.com>
Subject: Re: Reiser4 SCSI Bug?
Date: Sat, 29 Oct 2005 19:33:51 -0400	[thread overview]
Message-ID: <436406DF.8070104@wpi.edu> (raw)
In-Reply-To: <4364033C.5010200@namesys.com>

Hans Reiser wrote:
> 
> It should be not 256, but BIO_MAX_PAGES, yes?   Defining limits in two
> places is bad, yes?
> 
>

Yeah, I think the code is running into two different limits here. 
Reiser4 wants it to be nr, but limits it to BIO_MAX_PAGES.  However, 
apparently, the BIO_MAX_PAGES limit does not take into consideration the 
underlying 256 limit imposed by bio_alloc.

I'm not quite sure if having the two different limits is a bad thing in 
this case, unless BIO_MAX_PAGES can be made to (or is supposed to, and 
there's a bug) take into account the 256 limit.

I suppose the other solution is to not use bio_alloc et al due to the 
256 limit, and find another method that allows values as large as 
BIO_MAX_PAGES, under the current implementation, will grow to.

  reply	other threads:[~2005-10-29 23:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-28 17:49 Reiser4 SCSI Bug? Steve Olivieri
2005-10-29  0:27 ` Isaac Chanin
2005-10-29 16:06   ` Hans Reiser
2005-10-29 23:13     ` Isaac Chanin
2005-10-29 23:18       ` Hans Reiser
2005-10-29 23:33         ` Isaac Chanin [this message]
2005-10-30  3:22           ` Hans Reiser
2005-10-30  0:35             ` Isaac Chanin
2005-10-30  6:42               ` Hans Reiser
2005-10-31  2:18                 ` Steve Olivieri
2005-10-31  3:48                   ` Isaac Chanin
2005-10-31 18:31                     ` Steve Olivieri
2005-10-31  6:24       ` Alexander Zarochentsev
2005-10-31  7:42         ` Alexander Zarochentsev
2005-10-31  8:23           ` Hans Reiser
2005-10-30 22:36 ` Michael James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436406DF.8070104@wpi.edu \
    --to=chanin@wpi.edu \
    --cc=reiser@namesys.com \
    --cc=reiserfs-list@namesys.com \
    --cc=steve86@WPI.EDU \
    --cc=vs@thebsh.namesys.com \
    --cc=zam@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.