From: Pierre Ossman <drzeus-list@drzeus.cx>
To: ralf@linux-mips.org
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [FIXME] Comments on serial and MMC changes in MIPS merge
Date: Sun, 30 Oct 2005 12:00:38 +0100 [thread overview]
Message-ID: <4364A7D6.2060006@drzeus.cx> (raw)
In-Reply-To: <20051029220722.GI14039@flint.arm.linux.org.uk>
Russell King wrote:
> Some comments on the recent MIPS merge:
>
> 1. au1xxx mmc driver
>
> mmc_remove_host() does a safe shutdown of the MMC host, removing
> cards and then powering down. This must be called prior to the
> driver thinking of tearing anything down.
>
> As for those disable_irq()...enable_irq(), are you aware that MMC
> can start talking to the host as soon as you've called mmc_add_host() ?
>
I'm also concerned about the ammount of protocol awareness in this
driver. Is there a spec available for this hardware? Perhaps the MMC
layer can export more information so that we can avoid switches on
specific MMC commands?
Rgds
Pierre
next prev parent reply other threads:[~2005-10-30 11:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 22:07 [FIXME] Comments on serial and MMC changes in MIPS merge Russell King
2005-10-30 11:00 ` Pierre Ossman [this message]
2005-10-31 11:59 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4364A7D6.2060006@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.