From: Patrick McHardy <kaber@trash.net>
To: Yasuyuki KOZAKAI <yasuyuki.kozakai@toshiba.co.jp>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] make ipv6_find_hdr() find transport protocol header
Date: Sun, 30 Oct 2005 15:58:45 +0100 [thread overview]
Message-ID: <4364DFA5.7060405@trash.net> (raw)
In-Reply-To: <200509240857.j8O8vaQ2006429@toshiba.co.jp>
Yasuyuki KOZAKAI wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Sat, 17 Sep 2005 21:25:02 +0200
>
>>This patch looks great, applied. It looks like we could also replace
>>the code in ip6_packet_match, the special treatment of IPPROTO_ESP
>>doesn't look right anyway.
>
> Sounds good. ESP handling isn't difficult because ipv6_ext_hdr() doesn't
> check ESP. But special handling of Fragment header is necessary, to get
> "next header" field and fragment offset in it if packet isn't 1st fragment.
>
> Note that I didn't unify ipv6_skip_hder() because I plans a optimization around
> this.
>
> I've tested this patch with AH, ESP, Fragment header combinations, but
> have not tested with other extension headers because now I'm on trip and
> have only a laptop, sorry.
Finally applied, sorry for the delay.
prev parent reply other threads:[~2005-10-30 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-14 16:15 [PATCH] introduce ipv6_find_hdr to unify similar loops in IPv6 matches Yasuyuki KOZAKAI
2005-09-17 19:25 ` Patrick McHardy
2005-09-24 8:57 ` [PATCH] make ipv6_find_hdr() find transport protocol header Yasuyuki KOZAKAI
2005-10-30 14:58 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4364DFA5.7060405@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=yasuyuki.kozakai@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.