From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Changes to allow dynamic enabling/disabling of trace buffers
Date: Sun, 30 Oct 2005 23:02:41 +0000 [thread overview]
Message-ID: <43655111.5050403@blueyonder.co.uk> (raw)
In-Reply-To: <43654ED6.5070604@blueyonder.co.uk>
David Hopwood wrote:
> Rob Gardner wrote:
>
> // 3. Changing size ==> deallocate and reallocate? Or disallow?
> // User can just do a change to 0, then a change to the new size.
>
> They can, but the interface is slightly simpler if you allow this, and
> the implementation is also slightly shorter because you don't have to
> check for the error, or comment on it:
[...]
> The sentence "To change the size of an existing allocation, you must first
> deallocate it then reallocate it." should also be removed from the
> xc_tbuf_set_size doc comment.
For the implementation I gave, replace it with
"If the call fails (e.g. due to lack of memory), the size may be set to zero."
--
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
next prev parent reply other threads:[~2005-10-30 23:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-30 21:14 [PATCH] Changes to allow dynamic enabling/disabling of trace buffers Rob Gardner
2005-10-30 22:53 ` David Hopwood
2005-10-30 22:59 ` Rob Gardner
2005-10-30 23:02 ` David Hopwood [this message]
2005-10-31 7:54 ` Keir Fraser
2005-10-31 14:42 ` Rob Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43655111.5050403@blueyonder.co.uk \
--to=david.nospam.hopwood@blueyonder.co.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.