All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Declan Doherty <declan.doherty@intel.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
	stable@dpdk.org, chas3@att.com, radu.nicolau@intel.com,
	sharmila.podury@att.com
Subject: Re: [PATCH] net/bonding: fix slave activation simultaneously
Date: Mon, 14 May 2018 04:07:07 +0200	[thread overview]
Message-ID: <4366104.K65D46sZa3@xps> (raw)
In-Reply-To: <1524569370-6799-1-git-send-email-matan@mellanox.com>

Someone to review please?

24/04/2018 13:29, Matan Azrad:
> The bonding PMD decides to activate\deactivate its slaves according to
> the slaves link statuses.
> Thus, it registers to the LSC events of the slaves ports and
> activates\deactivates them from its LSC callbacks called asynchronously
> by the host thread when the slave link status is changed.
> 
> In addition, the bonding PMD uses the callback for slave activation
> when it tries to start it, this operation is probably called by the
> master thread.
> 
> Consequently, a slave may be activated in the same time by two
> different threads and may cause a lot of optional errors, for example,
> slave mempool recreation with the same name causes an error.
> 
> Synchronize the critical section in the LSC callback using a special
> new spinlock.
> 
> Fixes: 414b202343ce ("bonding: fix initial link status of slave")
> Fixes: a45b288ef21a ("bond: support link status polling")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>

  reply	other threads:[~2018-05-14  2:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 11:29 [PATCH] net/bonding: fix slave activation simultaneously Matan Azrad
2018-05-14  2:07 ` Thomas Monjalon [this message]
2018-05-14 11:45 ` Doherty, Declan
2018-05-14 12:41   ` [dpdk-stable] " Ferruh Yigit
2018-05-14 15:01     ` Chas Williams
2018-05-15  8:24       ` Matan Azrad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4366104.K65D46sZa3@xps \
    --to=thomas@monjalon.net \
    --cc=chas3@att.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=matan@mellanox.com \
    --cc=radu.nicolau@intel.com \
    --cc=sharmila.podury@att.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.