From: Michael Krufky <mkrufky@m1k.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-dvb-maintainer@linuxtv.org
Subject: [PATCH 35/37] dvb: Remove status check from nxt200x_readreg_multibyte
Date: Tue, 01 Nov 2005 03:16:31 -0500 [thread overview]
Message-ID: <4367245F.9080502@m1k.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 2 bytes --]
[-- Attachment #2: 2413.patch --]
[-- Type: text/x-patch, Size: 1178 bytes --]
From: Kirk Lapray <kirk.lapray@gmail.com>
- Remove status check from nxt200x_readreg_multibyte,
it really shouldn't be necessary.
Signed-off-by: Kirk Lapray <kirk.lapray@gmail.com>
Signed-off-by: Michael Krufky <mkrufky@m1k.net>
drivers/media/dvb/frontends/nxt200x.c | 18 ++++--------------
1 file changed, 4 insertions(+), 14 deletions(-)
--- linux-2.6.14-git3.orig/drivers/media/dvb/frontends/nxt200x.c
+++ linux-2.6.14-git3/drivers/media/dvb/frontends/nxt200x.c
@@ -239,26 +239,16 @@
buf = 0x80;
nxt200x_writebytes(state, 0x21, &buf, 1);
- /* read status */
- nxt200x_readbytes(state, 0x21, &buf, 1);
-
- if (buf == 0)
- {
- /* read the actual data */
- for(i = 0; i < len; i++) {
- nxt200x_readbytes(state, 0x36 + i, &data[i], 1);
- }
- return 0;
+ /* read the actual data */
+ for(i = 0; i < len; i++) {
+ nxt200x_readbytes(state, 0x36 + i, &data[i], 1);
}
+ return 0;
break;
default:
return -EINVAL;
break;
}
-
- printk(KERN_WARNING "nxt200x: Error reading multireg register 0x%02X\n",reg);
-
- return 0;
}
static void nxt200x_microcontroller_stop (struct nxt200x_state* state)
reply other threads:[~2005-11-01 8:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4367245F.9080502@m1k.net \
--to=mkrufky@m1k.net \
--cc=akpm@osdl.org \
--cc=linux-dvb-maintainer@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.