From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Knorr <kraxel@suse.de>
Subject: Re: "xm save" trouble -- deadlock?
Date: Wed, 02 Nov 2005 10:25:36 +0100
Message-ID: <43688610.2010601@suse.de>
References: <43679B4C.3030804@suse.de> <4367A2AF.2090707@suse.de>
	<20051101185456.GA21507@leeni.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20051101185456.GA21507@leeni.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ewan Mellor <ewan@xensource.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

   Hi,

> The code that does this is in XendCheckpoint.py:forkHelper.  It's using
> select.poll() and file.readline() to read from both the stdout and the
> stderr.  This is a pretty daft thing to do -- there's definitely potential for
> deadlock here.
 >
> I'll rewrite this to use a separate thread to pull the data from stderr, which
> should solve the problem.

Should be fixable without a new thread, I'll have a look. 
log.debug("stuff") ends up in /var/log/xend.log I guess?

   Gerd