Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
>>      hw_regs_t hw;
>>      memset(&hw, 0, sizeof(hw));
>> -    ide_init_hwif_ports(&hw, io, ctl, NULL);
>> +    ide_std_init_ports(&hw, io, ctl);
> 
> Could you separate this into another patch?
> 
> This change fixes ide-cs for some archs but OTOH we should verify that
> there are no ide-cs specific hacks in ide_init_hwif_ports() on other archs.
> 
Oops, you are correct. The main reason why I did this is this comment in
include/linux/ide.h:
 * ide_init_hwif_ports() is OBSOLETE and will be removed in 2.7 series.

Arch specific codes are in:
cris/v10
arm/sa1100
arch-m68knommu

Neither of which is using the irq parameter anyway, so it would make
sense to remove that interface completely.

Updated patch attached.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de