All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Krufky <mkrufky@m1k.net>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>,
	linux-dvb-maintainer@linuxtv.org,
	Kirk Lapray <kirk.lapray@gmail.com>
Subject: Re: [PATCH 3/3] dvb: nxt200x: Add function for nxt200x to change pll input
Date: Fri, 04 Nov 2005 00:02:40 -0500	[thread overview]
Message-ID: <436AEB70.3060900@m1k.net> (raw)
In-Reply-To: <436AEADB.9080802@m1k.net>

Michael Krufky wrote:

>From: Kirk Lapray <kirk.lapray@gmail.com>
>
>- Added function for nxt200x to change pll input
>- For VSB set to input 0, for QAM set to input 1
>- will only be set for cards that have set_pll_input defined
>
>Signed-off-by: Kirk Lapray <kirk.lapray@gmail.com>
>Signed-off-by: Michael Krufky <mkrufky@m1k.net>
>
> drivers/media/dvb/frontends/nxt200x.c |    9 +++++++--
> drivers/media/dvb/frontends/nxt200x.h |    3 +++
> 2 files changed, 10 insertions(+), 2 deletions(-)
>
>--- linux-2.6.14-git5.orig/drivers/media/dvb/frontends/nxt200x.c
>+++ linux-2.6.14-git5/drivers/media/dvb/frontends/nxt200x.c
>@@ -556,13 +556,18 @@ static int nxt200x_setup_frontend_parame
> 			if (state->config->set_ts_params)
> 				state->config->set_ts_params(fe, 1);
> 
>-			/* set to use cable input */
>-			buf[3] |= 0x08;
>+			/* set input */
>+			if (state->config->set_pll_input)
>+				state->config->set_pll_input(buf, 1);
> 			break;
> 		case VSB_8:
> 			/* Set non-punctured clock for VSB */
> 			if (state->config->set_ts_params)
> 				state->config->set_ts_params(fe, 0);
>+
>+			/* set input */
>+			if (state->config->set_pll_input)
>+				state->config->set_pll_input(buf, 0);
> 			break;
> 		default:
> 			return -EINVAL;
>--- linux-2.6.14-git5.orig/drivers/media/dvb/frontends/nxt200x.h
>+++ linux-2.6.14-git5/drivers/media/dvb/frontends/nxt200x.h
>@@ -42,6 +42,9 @@ struct nxt200x_config
> 	u8 pll_address;
> 	struct dvb_pll_desc *pll_desc;
> 
>+	/* used to set pll input */
>+	int (*set_pll_input)(u8* buf, int input);
>+
> 	/* need to set device param for start_dma */
> 	int (*set_ts_params)(struct dvb_frontend* fe, int is_punctured);
> };
>
Before anybody says it, I am aware of the whitespace issue right here.  
It is all over dvb-kernel, and we will be fixing this all at once, in a 
later patch.

Thank you,

Michael Krufky

      reply	other threads:[~2005-11-04  5:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-04  5:00 [PATCH 3/3] dvb: nxt200x: Add function for nxt200x to change pll input Michael Krufky
2005-11-04  5:02 ` Michael Krufky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=436AEB70.3060900@m1k.net \
    --to=mkrufky@m1k.net \
    --cc=akpm@osdl.org \
    --cc=kirk.lapray@gmail.com \
    --cc=linux-dvb-maintainer@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.