Re: [PATCH mptcp-next v9 8/8] mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

Thank you for the new version!

On 10/01/2025 08:30, Geliang Tang wrote:
> From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
> 
> Instead of only returning a text message with GENL_SET_ERR_MSG(),
> NL_SET_ERR_MSG_ATTR() can help the userspace developers by also
> reporting which attribute is faulty.
> 
> When the error is specific to an attribute, NL_SET_ERR_MSG_ATTR() is now
> used. The error messages have not been modified in this commit.
> 
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> ---
> v2:
>  - update the code related mptcp_userspace_pm_remove_id_zero_address()
>    since a new patch to drop "info" parameter of this patch is added.
> 
> v3:
>  - not use NL_SET_ERR_MSG_ATTR in mptcp_pm_nl_set_flags(), since 'attr'
>    will be removed in the commit "mptcp: add local & remote parameters for
>    set_flags".

It could still be set here, and removed in the other series (or we could
also use it in the other series, to uniform the errors, the helper has
access to 'info'), but OK, we had enough versions here.

Note that in mptcp_pm_nl_remove_doit(), there is one
GENL_SET_ERR_MSG_FMT() left: NL_SET_ERR_MSG_ATTR_FMT() can be used
instead. I can fix that when applying the patch if that's OK for you.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.