Re: Re: [PATCH 0/8] fbcon: Console Rotation

[Knut Petersen <Knut_Petersen@t-online.de>]

>>>>Unfortunately though, this patch substantially changed fbcon.c, so
>>>> any other patch affecting that file may have to wait or risk
>>>> conflicts in the future.
>>>>        
>>>>
>>>Yes, that's a problem.  We _could_ just slam this in this week and grit our
>>>teeth.  How would you evaluate the risk of regressions to existing setups?
>>>      
>>>
>>Low, if rotation is disabled. Most of the rotation code will be
>>compiled as no-ops.
>>    
>>
>
>Ho hum, OK.  Fingers crossed...
>
>  
>
If those patches would introduce bugs not related to rotated screens we 
would
find those bugs quickly as every single user tests those routines at 
least during
the boot process.

Screen rotation is a usefull feature. Not for everybody, but there are 
lots of people
who would appreciate it. I vote for including them now, asap. This would 
give the
maintainers of the hardware drivers a real argument to fix x-panning, or 
at least to
disable it in *check_var()  in case it is broken or not supported by the 
hardware.

cu,
 knut




-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php