All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Harald Welte <laforge@netfilter.org>,
	Netfilter Development Mailinglist
	<netfilter-devel@lists.netfilter.org>
Subject: Re: [PATCH 8/8] Add missing sizecheckings
Date: Tue, 08 Nov 2005 19:17:48 +0100	[thread overview]
Message-ID: <4370EBCC.9040308@netfilter.org> (raw)
In-Reply-To: <4370B08B.30507@trash.net>

Patrick McHardy wrote:
> Pablo Neira wrote:
> 
>>Add missing sizecheckings. Thanks Patrick Mchardy for the hint. This
>>patch requires the previous (7/8), otherwise it would break ctnetlink.
> 
> 
> Both patches look good to me, although you probably should use
> size_t or unsigned int for the cta_.*_min arrays, otherwise
> I think gcc-4.x will complain.

yes, agreed. I'll resend this patch using size_t late at night.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

      reply	other threads:[~2005-11-08 18:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08  1:45 [PATCH 8/8] Add missing sizecheckings Pablo Neira
2005-11-08 14:04 ` Patrick McHardy
2005-11-08 18:17   ` Pablo Neira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4370EBCC.9040308@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.