All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: akpm@osdl.org
Cc: axboe@suse.de, htejun@hotmail.com,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: + elevator-init-fixes.patch added to -mm tree
Date: Tue, 08 Nov 2005 10:38:20 -0800	[thread overview]
Message-ID: <4370F09C.1050306@vmware.com> (raw)
In-Reply-To: <200511080351.jA83psjw016612@shell0.pdx.osdl.net>

[-- Attachment #1: Type: text/plain, Size: 306 bytes --]

akpm@osdl.org wrote:

>The patch titled
>
>     Elevator init fixes
>
>has been added to the -mm tree.  Its filename is
>
>     elevator-init-fixes.patch
>  
>

In addition to the first patch, which is probably goodness, I found the 
cause of my panic - applying this patch fixes it and now I am booting.


[-- Attachment #2: elevator-obviously-broken-fix --]
[-- Type: text/plain, Size: 600 bytes --]


Index: linux-2.6.14/drivers/block/elevator.c
===================================================================
--- linux-2.6.14.orig/drivers/block/elevator.c	2005-11-07 08:07:15.000000000 -0800
+++ linux-2.6.14/drivers/block/elevator.c	2005-11-08 02:14:35.727328656 -0800
@@ -155,9 +155,10 @@
  	/*
  	 * If the given scheduler is not available, fall back to no-op.
  	 */
- 	if (!(e = elevator_find(chosen_elevator)))
+ 	if ((e = elevator_find(chosen_elevator)))
+		elevator_put(e);
+	else
  		strcpy(chosen_elevator, "noop");
-	elevator_put(e);
 }
 
 static int __init elevator_setup(char *str)

       reply	other threads:[~2005-11-08 18:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200511080351.jA83psjw016612@shell0.pdx.osdl.net>
2005-11-08 18:38 ` Zachary Amsden [this message]
2005-11-09  7:39   ` + elevator-init-fixes.patch added to -mm tree Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4370F09C.1050306@vmware.com \
    --to=zach@vmware.com \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=htejun@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.