From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2666FC43460 for ; Sat, 24 Apr 2021 20:38:21 +0000 (UTC) Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EDB7613BF for ; Sat, 24 Apr 2021 20:38:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EDB7613BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vt.edu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kernelnewbies-bounces@kernelnewbies.org Received: from localhost ([::1] helo=shelob.surriel.com) by shelob.surriel.com with esmtp (Exim 4.94) (envelope-from ) id 1laP2R-0003aG-C1; Sat, 24 Apr 2021 16:38:03 -0400 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by shelob.surriel.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1laP2L-0003Sz-6s for kernelnewbies@kernelnewbies.org; Sat, 24 Apr 2021 16:37:57 -0400 Received: by mail-qk1-x736.google.com with SMTP id 8so19270323qkv.8 for ; Sat, 24 Apr 2021 13:37:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=oW6fHo0XgbJMHm3nIz/zivLoyUK1+fsOgv+m//0Lr+Y=; b=j0jrGV9wWym3LHmXjyrGGAtHD+EPv6neXK4ZppbMcTIH1eCJUMTCIRM+y+pFFgoc+f uTBTKdZBkxlJ6CgH+KvKiObz61bGSzWDNz0JHysAtKftkTPEwCB0Tgiv8y+C2GsrXw80 r9jxh9kK0hsVvhrdfsRlCFmC7TnOqeCLNWaG/7zgFTBH7Ikj0gKBn+vdCpIVsL2K3FSd 4LkEI4d/Oyg/Nk7yUmjDTQxbnaCMMQg9w6+APcM5fpOGn8EuLfnaXsyqTwgAcxlLLC+U 6/gSXh65lEvtNQJVp3U4unwP8tE0ggewPyYoSoAGpDrTtIu628A+h1vKoZf8fbmColM3 AJ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=oW6fHo0XgbJMHm3nIz/zivLoyUK1+fsOgv+m//0Lr+Y=; b=qVS2ubqF1ljR4s3j91hCZvikw84SRmvyS+GFUaCXppCcUFePs6X9o1uM2MQSwPTi1l g5dH0X6Ys9zVahaSQoUSbBmX7Lc1pL6J3/RgMIiFCPsuo1rKCQtVYtnU3KxuOoETMq/d o5pI6pLOZShdi4W7TBoszfRvCfyd6scNBd1QvIxVXJz61VSYkSNJ27QpcF60TcoeAF50 mHUe07OFmJo5j8VPDcQdcyeuTyGDRrk77H6caAkhHaTnCjp2ViyLbaoDKS5RKVw7xUmI rfqS40vVm657p7lQRGPjyqvbQUaIi0eg5go+t6DPFTOMEJLa8QH/TYj4TdsF5piWMrEO ZxUw== X-Gm-Message-State: AOAM533Junlr+N1hMaWvHUBsWH7/tCw+m+BIZa+yrKAwY9+vtzFVxwMb ZTYDhqK5waq7OU6SKZMueABAGQ== X-Google-Smtp-Source: ABdhPJyVq9Ibxe7BudPyDHcP2LR9YC3NDUzbDZpdyYnX8y8nb6U346ejzgVct+TFFz2/NUhwEnU9Iw== X-Received: by 2002:a37:b807:: with SMTP id i7mr10172017qkf.126.1619296674918; Sat, 24 Apr 2021 13:37:54 -0700 (PDT) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id a30sm7417609qtn.4.2021.04.24.13.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Apr 2021 13:37:54 -0700 (PDT) From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Anupama K Patil Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices In-Reply-To: <20210424194301.jmsqpycvsm7izbk3@ubuntu> References: <20210424194301.jmsqpycvsm7izbk3@ubuntu> Mime-Version: 1.0 Date: Sat, 24 Apr 2021 16:37:52 -0400 Message-ID: <437247.1619296672@turing-police> Cc: kernelnewbies@kernelnewbies.org, gregkh@linuxfoundation.org, "Rafael J. Wysocki" , bkkarthik@pesu.pes.edu, linux-kernel@vger.kernel.org, Jaroslav Kysela , linux-acpi@vger.kernel.org, skhan@linuxfoundation.org X-BeenThere: kernelnewbies@kernelnewbies.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Learn about the Linux kernel List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8216659634261191647==" Errors-To: kernelnewbies-bounces@kernelnewbies.org --===============8216659634261191647== Content-Type: multipart/signed; boundary="==_Exmh_1619296672_197072P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit --==_Exmh_1619296672_197072P Content-Type: text/plain; charset=us-ascii On Sun, 25 Apr 2021 01:13:01 +0530, Anupama K Patil said: > Changed sprintf() to the kernel-space function scnprintf() as it returns > the actual number of bytes written. > + if (!bus->procdir) { > + scnprintf(name, 16, "%02x", bus->number); > + scnprintf(name, 16, "%02x", dev->number); Why do this when you don't *use* the number of bytes written, but instead ignore the value returned? For bonus points: Given the %02x format, under what conditions can it return a value other than 2? --==_Exmh_1619296672_197072P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBYISBoAdmEQWDXROgAQKzRA/+PJmouXYYzm0CMp+Zv8IbUmPXbjIeNsij fiE4Qr0KeYkEoKquUxfeEPkSZ5UBDPajAgsbcwSO8dJtmzaD8+MPMPyNkDkNE7i6 vvIWfuernYrS5JLYIGx1Vg4bUAOodSOUIQSfkO8U2U1I4sQ4JBLQC54ea1vL+G2O lgjNKsRtBW5o61ouJrW2kGGMzhdN179nIYNF7WspXB9twJClP+vVqk2h0fgtgu7H SZ+bEF3Z+kMam/gHjbl2Y5N0+Ji5LX/SuXxb6rlq6l3Btb2Mj77LNt2FnK5OpDsp K9Cdo5uLZu5cdJq7QDfLUgWf2WbIuUe/902VENkXLOOYQsnZhdVkMy3matZStpQW Ovl57yuPj8T/3d4zvLhOTSlXUDobUvjOEZHZZEprNyd3ET20btsT1Ouv6/RgPwiu Wg0/5EeTeV0E4cIrFgDSN7miIwpdiBtgQtvVGEuxwMF3gn0VJV7EMG2ISl70H15y /eED5Z6PVDXx6fZYdxLmN9kJS/9wqpQzfyoRS34BM0GJhT6xZ1WfcADmZqPt3GbH mtKzG1CQGxOqyr5BfH0K348+fm+HHpM6uZPIBYYgaMoAerMhLJHlmLWzaHovZEmg xY3HbW/e7f82C32nkjjsvc6tFfwnCcst66vEPJ11UniXvv/3FW/xON8avRq8YaTf osmvFBapi/s= =c7CK -----END PGP SIGNATURE----- --==_Exmh_1619296672_197072P-- --===============8216659634261191647== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kernelnewbies mailing list Kernelnewbies@kernelnewbies.org https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies --===============8216659634261191647==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93698C433ED for ; Sat, 24 Apr 2021 20:37:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 622016117A for ; Sat, 24 Apr 2021 20:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234040AbhDXUig (ORCPT ); Sat, 24 Apr 2021 16:38:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232546AbhDXUif (ORCPT ); Sat, 24 Apr 2021 16:38:35 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCB74C061574 for ; Sat, 24 Apr 2021 13:37:55 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id u20so20845866qku.10 for ; Sat, 24 Apr 2021 13:37:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vt-edu.20150623.gappssmtp.com; s=20150623; h=sender:from:to:cc:subject:in-reply-to:references:mime-version :content-transfer-encoding:date:message-id; bh=oW6fHo0XgbJMHm3nIz/zivLoyUK1+fsOgv+m//0Lr+Y=; b=j0jrGV9wWym3LHmXjyrGGAtHD+EPv6neXK4ZppbMcTIH1eCJUMTCIRM+y+pFFgoc+f uTBTKdZBkxlJ6CgH+KvKiObz61bGSzWDNz0JHysAtKftkTPEwCB0Tgiv8y+C2GsrXw80 r9jxh9kK0hsVvhrdfsRlCFmC7TnOqeCLNWaG/7zgFTBH7Ikj0gKBn+vdCpIVsL2K3FSd 4LkEI4d/Oyg/Nk7yUmjDTQxbnaCMMQg9w6+APcM5fpOGn8EuLfnaXsyqTwgAcxlLLC+U 6/gSXh65lEvtNQJVp3U4unwP8tE0ggewPyYoSoAGpDrTtIu628A+h1vKoZf8fbmColM3 AJ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:in-reply-to:references :mime-version:content-transfer-encoding:date:message-id; bh=oW6fHo0XgbJMHm3nIz/zivLoyUK1+fsOgv+m//0Lr+Y=; b=Vm9/4d4P3my0V5VT88mdCfon5QNURCbe76aztbWXL/Rv/bgG6c5HHeM9oSdfrzdgNf N8aoAl8gh7+R55gpTKgfRWazyBUOg+1pcRA22z669tXemiuOusqTJX4reTYxMJalBUtd WIOGBJBSllKrwf50VUWMNkeK5kbziJwVIWyDstIak980YBzNxXZnEraJv/kLblqrIbUp d6qXT8ZoAmuSwQs8Tl9UGHdMouSK0QciHwKqh/wy9azjmbo7HCT3OFfNRxab/1NEZmUl dduwrsptOJLXPa8RdOYk61zNzgL7GyltVezofy7WIiCS1hxlM5yCt94AaTdJsSPMfgvd ohhg== X-Gm-Message-State: AOAM531gE/JF8OwgeM3B5Y2TN5yy/6G3nxtxjb1FVnIV61LQM0X1qIbP U4MJxT7vU3xHlWDudcjjH/lf3A== X-Google-Smtp-Source: ABdhPJyVq9Ibxe7BudPyDHcP2LR9YC3NDUzbDZpdyYnX8y8nb6U346ejzgVct+TFFz2/NUhwEnU9Iw== X-Received: by 2002:a37:b807:: with SMTP id i7mr10172017qkf.126.1619296674918; Sat, 24 Apr 2021 13:37:54 -0700 (PDT) Received: from turing-police ([2601:5c0:c380:d61::359]) by smtp.gmail.com with ESMTPSA id a30sm7417609qtn.4.2021.04.24.13.37.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 24 Apr 2021 13:37:54 -0700 (PDT) Sender: Valdis Kletnieks From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Google-Original-From: "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev To: Anupama K Patil Cc: Jaroslav Kysela , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, bkkarthik@pesu.pes.edu, gregkh@linuxfoundation.org, kernelnewbies@kernelnewbies.org Subject: Re: [PATCH] drivers: pnp: proc.c: Handle errors while attaching devices In-Reply-To: <20210424194301.jmsqpycvsm7izbk3@ubuntu> References: <20210424194301.jmsqpycvsm7izbk3@ubuntu> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==_Exmh_1619296672_197072P"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Date: Sat, 24 Apr 2021 16:37:52 -0400 Message-ID: <437247.1619296672@turing-police> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org --==_Exmh_1619296672_197072P Content-Type: text/plain; charset=us-ascii On Sun, 25 Apr 2021 01:13:01 +0530, Anupama K Patil said: > Changed sprintf() to the kernel-space function scnprintf() as it returns > the actual number of bytes written. > + if (!bus->procdir) { > + scnprintf(name, 16, "%02x", bus->number); > + scnprintf(name, 16, "%02x", dev->number); Why do this when you don't *use* the number of bytes written, but instead ignore the value returned? For bonus points: Given the %02x format, under what conditions can it return a value other than 2? --==_Exmh_1619296672_197072P Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Comment: Exmh version 2.9.0 11/07/2018 iQIVAwUBYISBoAdmEQWDXROgAQKzRA/+PJmouXYYzm0CMp+Zv8IbUmPXbjIeNsij fiE4Qr0KeYkEoKquUxfeEPkSZ5UBDPajAgsbcwSO8dJtmzaD8+MPMPyNkDkNE7i6 vvIWfuernYrS5JLYIGx1Vg4bUAOodSOUIQSfkO8U2U1I4sQ4JBLQC54ea1vL+G2O lgjNKsRtBW5o61ouJrW2kGGMzhdN179nIYNF7WspXB9twJClP+vVqk2h0fgtgu7H SZ+bEF3Z+kMam/gHjbl2Y5N0+Ji5LX/SuXxb6rlq6l3Btb2Mj77LNt2FnK5OpDsp K9Cdo5uLZu5cdJq7QDfLUgWf2WbIuUe/902VENkXLOOYQsnZhdVkMy3matZStpQW Ovl57yuPj8T/3d4zvLhOTSlXUDobUvjOEZHZZEprNyd3ET20btsT1Ouv6/RgPwiu Wg0/5EeTeV0E4cIrFgDSN7miIwpdiBtgQtvVGEuxwMF3gn0VJV7EMG2ISl70H15y /eED5Z6PVDXx6fZYdxLmN9kJS/9wqpQzfyoRS34BM0GJhT6xZ1WfcADmZqPt3GbH mtKzG1CQGxOqyr5BfH0K348+fm+HHpM6uZPIBYYgaMoAerMhLJHlmLWzaHovZEmg xY3HbW/e7f82C32nkjjsvc6tFfwnCcst66vEPJ11UniXvv/3FW/xON8avRq8YaTf osmvFBapi/s= =c7CK -----END PGP SIGNATURE----- --==_Exmh_1619296672_197072P--