From: Ivan Gyurdiev <ivg2@cornell.edu>
To: selinux@tycho.nsa.gov
Cc: Stephen Smalley <sds@tycho.nsa.gov>
Subject: [ SEMANAGE ] Fix hidden declarations
Date: Wed, 09 Nov 2005 18:17:24 -0500 [thread overview]
Message-ID: <43728384.3020508@cornell.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
The hidden declarations are still a mystery to me. They are present in
half the functions, and missing in the other half. I'm sure there's a
reason for this, but since I don't quite understand the pattern, I'll
leave them alone. There's no hidden declarations for _local.c, and
_policy.c, and they are missing for some of the functions in _record.c.
This patch:
- removes the hidden proto for sepol_user_exists(), and
sepol_seuser_iterate(), which make those functions invisible (no
hidden_def, not sure if one should be added).
- changes two cases of hidden_proto in iface_record.c to hidden_def,
because that just looks wrong.
[-- Attachment #2: libsemanage.hidden_fix.diff --]
[-- Type: text/x-patch, Size: 1939 bytes --]
diff -Naurp --exclude CVS --exclude ChangeLog --exclude VERSION old/libsemanage/src/iface_record.c new/libsemanage/src/iface_record.c
--- old/libsemanage/src/iface_record.c 2005-11-08 09:32:57.000000000 -0500
+++ new/libsemanage/src/iface_record.c 2005-11-09 18:05:51.000000000 -0500
@@ -115,14 +115,14 @@ int semanage_iface_clone(
return sepol_iface_clone(handle->sepolh, iface, iface_ptr);
}
-hidden_proto(semanage_iface_clone)
+hidden_def(semanage_iface_clone)
void semanage_iface_free(
semanage_iface_t* iface) {
sepol_iface_free(iface);
}
-hidden_proto(semanage_iface_free)
+hidden_def(semanage_iface_free)
/* Record base functions */
record_table_t SEMANAGE_IFACE_RTABLE = {
diff -Naurp --exclude CVS --exclude ChangeLog --exclude VERSION old/libsemanage/src/seuser_internal.h new/libsemanage/src/seuser_internal.h
--- old/libsemanage/src/seuser_internal.h 2005-11-08 09:32:57.000000000 -0500
+++ new/libsemanage/src/seuser_internal.h 2005-11-09 18:04:27.000000000 -0500
@@ -9,7 +9,6 @@ hidden_proto(semanage_seuser_free)
hidden_proto(semanage_seuser_get_mlsrange)
hidden_proto(semanage_seuser_get_name)
hidden_proto(semanage_seuser_get_sename)
-hidden_proto(semanage_seuser_iterate)
hidden_proto(semanage_seuser_key_create)
hidden_proto(semanage_seuser_key_extract)
hidden_proto(semanage_seuser_key_free)
diff -Naurp --exclude CVS --exclude ChangeLog --exclude VERSION old/libsemanage/src/user_internal.h new/libsemanage/src/user_internal.h
--- old/libsemanage/src/user_internal.h 2005-11-08 09:32:57.000000000 -0500
+++ new/libsemanage/src/user_internal.h 2005-11-09 18:04:11.000000000 -0500
@@ -7,7 +7,6 @@ hidden_proto(semanage_user_add_role)
hidden_proto(semanage_user_clone)
hidden_proto(semanage_user_compare)
hidden_proto(semanage_user_create)
-hidden_proto(semanage_user_exists)
hidden_proto(semanage_user_free)
hidden_proto(semanage_user_get_defrole)
hidden_proto(semanage_user_get_mlslevel)
next reply other threads:[~2005-11-09 23:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-09 23:17 Ivan Gyurdiev [this message]
2005-11-10 13:22 ` [ SEMANAGE ] Fix hidden declarations Stephen Smalley
2005-11-10 13:43 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43728384.3020508@cornell.edu \
--to=ivg2@cornell.edu \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.