From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Subject: Re: [PATCH] ip_conntrack_proto_tcp Date: Fri, 11 Nov 2005 14:00:23 +0100 Message-ID: <437495E7.5050500@eurodev.net> References: <1131637730.14044.12.camel@quant> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: coreteam@netfilter.org, netfilter-devel@lists.netfilter.org Return-path: To: Vlad Drukker In-Reply-To: <1131637730.14044.12.camel@quant> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Vlad Drukker wrote: > Attached patch for ip_conntrack to account TCP sessions started with SYN > +PUSH flags. Looks weird, but some HW vendors do TCP their own way. > > Let's earn some points from RFC 1025. I see this patch like a sort of workaround to make broken devices with the TCP connection tracking, right? In that case, I don't think that it's a good idea polluting our code with workarounds for every existing broken device. The HW vendors must fix their devices. -- Pablo