Re: [PATCH 21/20] v4l: prevent saa7134 alsa undefined warnings

[Michael Krufky <mkrufky@linuxtv.org>]

Takashi Iwai wrote:
> At Thu, 10 Nov 2005 17:37:58 -0500,
> Mike Krufky wrote:
> 
>>Prevent the following build warnings:
>>
>>*** Warning: "snd_card_free" 
>>*** Warning: "snd_card_register" 
>>*** Warning: "snd_device_new" 
>>*** Warning: "snd_card_new" 
>>*** Warning: "snd_ctl_add"
>>*** Warning: "snd_ctl_new1" 
>>*** Warning: "snd_pcm_set_ops" 
>>*** Warning: "snd_pcm_new"
>>*** Warning: "snd_pcm_lib_ioctl" 
>>*** Warning: "snd_pcm_hw_constraint_integer" 
>>*** Warning: "snd_pcm_stop" 
>>*** Warning: "snd_pcm_period_elapsed" 
>>[drivers/media/video/saa7134/saa7134-alsa.ko] undefined!
>>
>>Signed-off-by: Michael Krufky <mkrufky@m1k.net>
>>Acked-by: Mauro Carvalho Chehab <mchehab@brturbo.com.br>
>>
>> drivers/media/video/saa7134/Kconfig |    2 +-
>> 1 files changed, 1 insertion(+), 1 deletion(-)
>>
>>--- linux.orig/drivers/media/video/saa7134/Kconfig
>>+++ linux/drivers/media/video/saa7134/Kconfig
>>@@ -1,6 +1,6 @@
>> config VIDEO_SAA7134
>> 	tristate "Philips SAA7134 support"
>>-	depends on VIDEO_DEV && PCI && I2C && SOUND
>>+	depends on VIDEO_DEV && PCI && I2C && SOUND && SND && SND_PCM_OSS
> 
> 
> No, this driver should select SND_PCM_OSS, instead.
> 
> 
> Takashi

Yes, I realized that after Andrew applied the patch.  We will send a 
correction in our next patchset.

-Michael Krufky