Re: [KJ] [PATCH 4/9] Create helper for /proc/slabinfo

[Matthew Dobson <colpatch@us.ibm.com>]

walter harms wrote:
> hi Matthew,
> just to have less #if in the code. it maybe usefull to make something
> like that in the beginning:
> 
> #if STATS
> #define STATS_VERSION "slabinfo - version: 2.1 (statistics)"
> #else
> #define STATS_VERSION "slabinfo - version: 2.1"
> #endif

We could do that, but we'd still need this #if in the function:

>>  #if STATS
>> -        seq_puts(m, " : globalstat <listallocs> <maxobjs> <grown>
>> <reaped>"
>> -                " <error> <maxfreeable> <nodeallocs> <remotefrees>");
>> -        seq_puts(m, " : cpustat <allochit> <allocmiss> <freehit>
>> <freemiss>");
>> +    seq_puts(m, " : globalstat <listallocs> <maxobjs> <grown> <reaped> "
>> +         "<error> <maxfreeable> <nodeallocs> <remotefrees>");
>> +    seq_puts(m, " : cpustat <allochit> <allocmiss> <freehit>
>> <freemiss>");
>>  #endif

so I don't think it buys us that much.  If it weren't for the second #if, I
would tend to agree with you.

> note i have silently droped "\n" are they realy needed ?

That I think is a big no-no.  This file is meant to be parsed by scripts,
so ANY change to the format would potentially break people's scripts and
would need an OK from the maintainer as well as a version number change
(aka: slabinfo - version: 2.2), and I think that is unecessary.

Thanks for your review.

-Matt
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors