All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: James Courtier-Dutton <James@superbug.demon.co.uk>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.15-rc1] libata: fix passthru for slave devices
Date: Sat, 12 Nov 2005 22:11:09 -0500	[thread overview]
Message-ID: <4376AECD.2040907@rtr.ca> (raw)
In-Reply-To: <4376AD3C.2070105@pobox.com>


AGAIN, with *feeling*.
(I'm in the middle of a complete distro-upgrade on my machine here,
so my tools are only half functional now.  Fix any residual formatting
issues yourself, please.)

- fixed whitespace, fixed third instance of "s/command/device".

> Compiles, not tested.

Signed-off-by: Mark Lord <mlord@pobox.com>

--- linux-2.6.15-rc1/drivers/scsi/libata-scsi.c.orig    2005-11-11 20:43:36.000000000 -0500
+++ linux/drivers/scsi/libata-scsi.c    2005-11-12 18:45:43.000000000 -0500
@@ -2276,6 +2276,12 @@
		tf->device = scsicmd[8];
		tf->command = scsicmd[9];
	}
+	/*
+	 * If slave is possible, enforce correct master/slave bit for this port:
+	 */
+	if ((qc->ap->flags & ATA_FLAG_SLAVE_POSS))
+	tf->device = qc->dev->devno ?
+		tf->device | ATA_DEV1 : tf->device & ~ATA_DEV1;

	/*
	 * Filter SET_FEATURES - XFER MODE command -- otherwise,


  reply	other threads:[~2005-11-13  3:11 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-12 10:55 libata-passthrough problem James Courtier-Dutton
2005-11-12 15:18 ` Mark Lord
2005-11-12 17:57   ` Jeff Garzik
2005-11-12 19:53     ` Mark Lord
2005-11-12 19:56       ` Mark Lord
2005-11-12 23:19         ` Jeff Garzik
2005-11-12 23:54           ` [PATCH 2.6.15-rc1] libata: fix passthru for slave devices Mark Lord
2005-11-12 23:55             ` [PATCH 2.6.15-rc1] libata: fix comments on ata_tf_from_fis() Mark Lord
2005-11-13  0:15             ` [PATCH 2.6.15-rc1] libata: fix passthru for slave devices Jeff Garzik
2005-11-13  2:50               ` Mark Lord
2005-11-13  3:20                 ` Jeff Garzik
2005-11-13  4:37                   ` Mark Lord
2005-11-13  0:16             ` Jeff Garzik
2005-11-13  2:48               ` Mark Lord
2005-11-13  3:04             ` Mark Lord
2005-11-13  3:11               ` Mark Lord [this message]
2005-11-12 23:19       ` libata-passthrough problem Jeff Garzik
2005-11-12 23:40         ` Mark Lord
2005-11-13 15:13           ` James Courtier-Dutton
2005-11-13 17:01             ` Mark Lord
2005-11-13 17:03               ` Mark Lord
2005-11-13 20:17                 ` James Courtier-Dutton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4376AECD.2040907@rtr.ca \
    --to=liml@rtr.ca \
    --cc=James@superbug.demon.co.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.