From: "H. Peter Anvin" <hpa@zytor.com>
To: Junio C Hamano <junkio@cox.net>
Cc: Andreas Ericsson <exon@op5.se>, git@vger.kernel.org
Subject: Re: [PATCH] git-daemon: --inetd implies --syslog
Date: Mon, 14 Nov 2005 15:59:23 -0800 [thread overview]
Message-ID: <437924DB.1060602@zytor.com> (raw)
In-Reply-To: <7vlkzrx84p.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano wrote:
>
> Thanks; I am OK with what you are trying to do with this change,
> except that:
>
> - I suspect closing stderr is still needed (the "workaround"
> was about inetd connection sending output to both fd 1 and 2
> to the client, which would corrupt the protocol conversation
> when exec'ed program writes anything to its standard error
> stream).
>
> - I would have preferred the removal of needless else as a
> separate cleanup patch (this is minor).
>
> Peter, I am CC'ing this to you because I do not know how you run
> the daemon on kernel.org machines -- I suspect you use --syslog
> already and am hoping you are OK with this change.
Yeah, I use --inetd --syslog.
-hpa
prev parent reply other threads:[~2005-11-14 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 16:41 [PATCH] git-daemon: --inetd implies --syslog Andreas Ericsson
2005-11-14 20:54 ` Junio C Hamano
2005-11-14 21:23 ` Andreas Ericsson
2005-11-14 22:01 ` Junio C Hamano
2005-11-14 23:59 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437924DB.1060602@zytor.com \
--to=hpa@zytor.com \
--cc=exon@op5.se \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.