From: Ivan Gyurdiev <ivg2@cornell.edu>
To: Ivan Gyurdiev <ivg2@cornell.edu>
Cc: Chad Sellers <csellers@tresys.com>,
"'Daniel J Walsh'" <dwalsh@redhat.com>,
selinux-dev@tresys.com, Stephen Smalley <sds@tycho.nsa.gov>,
selinux@tycho.nsa.gov
Subject: Re: [PATCH] move genhomedircon call out of transaction
Date: Mon, 14 Nov 2005 23:02:52 -0500 [thread overview]
Message-ID: <43795DEC.6080506@cornell.edu> (raw)
In-Reply-To: <4379548D.3010801@cornell.edu>
>
> On the other hand, genhomedir called outside libsemanage has a race in
> itself, because changes can be introduced between the time you call
> user_list, and seuser_list. It seems you're moving the place it's
> called to the end of install_sandbox (hard to tell without -p flag),
> so if it's called within libsemanage, that won't be a problem (active
> lock released, transaction lock still held, concurrent commit not
> possible).
Really, genhomedircon should be using a transaction, which is both safer
(avoids race), and faster (requires only 1 policydb_read, as opposed to
2). However, I don't know how you'd call it within the original
transaction...
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2005-11-15 4:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 22:09 [PATCH] move genhomedircon call out of transaction Chad Sellers
2005-11-14 23:02 ` Ivan Gyurdiev
2005-11-14 23:07 ` Ivan Gyurdiev
2005-11-15 1:10 ` Chad Sellers
2005-11-15 3:22 ` Ivan Gyurdiev
2005-11-15 4:02 ` Ivan Gyurdiev [this message]
2005-11-15 13:23 ` Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43795DEC.6080506@cornell.edu \
--to=ivg2@cornell.edu \
--cc=csellers@tresys.com \
--cc=dwalsh@redhat.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux-dev@tresys.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.