From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lithops.sigma-star.at ([195.201.40.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaNou-00FQ8K-9F for linux-um@lists.infradead.org; Mon, 19 Sep 2022 20:56:50 +0000 Date: Mon, 19 Sep 2022 22:56:44 +0200 (CEST) From: Richard Weinberger Message-ID: <437983532.241061.1663621004742.JavaMail.zimbra@nod.at> In-Reply-To: <39e063ad-208d-f5f0-9807-eedcf0db1692@infradead.org> References: <20220823010830.2675419-1-davidgow@google.com> <39e063ad-208d-f5f0-9807-eedcf0db1692@infradead.org> Subject: Re: [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: Randy Dunlap , davidgow Cc: anton ivanov , Johannes Berg , Nick Desaulniers , tglx , mingo , dave hansen , torvalds , Brendan Higgins , Daniel Latypov , linux-um , linux-kernel , kunit-dev@googlegroups.com, x86 LS0tLS0gVXJzcHLDvG5nbGljaGUgTWFpbCAtLS0tLQo+IFZvbjogIlJhbmR5IER1bmxhcCIgPHJk dW5sYXBAaW5mcmFkZWFkLm9yZz4KPj4gTGluazoKPj4gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9w dWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0L2NvbW1pdC8/aWQ9ZmZj ZjljNTcwMGU0OWMwYWVlNDJkY2JhOWExMmJhMjEzMzhlODEzNgo+PiBMaW5rOgo+PiBodHRwczov L3NvdXJjZXdhcmUub3JnL2dpdC8/cD1iaW51dGlscy1nZGIuZ2l0O2E9Y29tbWl0O2g9YmE5NTFh ZmI5OTkxMmRhMDFhNmU4NDM0MTI2YjhmYWM3YWE3NTEwNwo+PiBTaWduZWQtb2ZmLWJ5OiBEYXZp ZCBHb3cgPGRhdmlkZ293QGdvb2dsZS5jb20+Cj4gCj4gQWNrZWQtYnk6IFJhbmR5IER1bmxhcCA8 cmR1bmxhcEBpbmZyYWRlYWQub3JnPiAjIGJ1aWxkLXRlc3RlZAoKVGhpcyBwYXRjaCBjYXVzZXMg YSBidWlsZCBlcnJvciBvbiBvbmUgb2YgbXkgc3lzdGVtczoKCi91c3IvbGliNjQvZ2NjL3g4Nl82 NC1zdXNlLWxpbnV4LzcvLi4vLi4vLi4vLi4veDg2XzY0LXN1c2UtbGludXgvYmluL2xkOiB1bnJl Y29nbml6ZWQgb3B0aW9uICctLW5vLXdhcm4tcnd4LXNlZ21lbnRzJwovdXNyL2xpYjY0L2djYy94 ODZfNjQtc3VzZS1saW51eC83Ly4uLy4uLy4uLy4uL3g4Nl82NC1zdXNlLWxpbnV4L2Jpbi9sZDog dXNlIHRoZSAtLWhlbHAgb3B0aW9uIGZvciB1c2FnZSBpbmZvcm1hdGlvbgpjb2xsZWN0MjogZXJy b3I6IGxkIHJldHVybmVkIDEgZXhpdCBzdGF0dXMKCkp1c3QgbGlrZSBpbiBjb21taXQgZmZjZjlj NTcwMGU0ICgieDg2OiBsaW5rIHZkc28gYW5kIGJvb3Qgd2l0aCAteiBub2V4ZWNzdGFjayAtLW5v LXdhcm4tcnd4LXNlZ21lbnRzIikgeW91IG5lZWQgdG8KdGVzdCBmb3IgaXQuCgpUaGFua3MsCi8v cmljaGFyZAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K bGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDov L2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC11bQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBCA5ECAAA1 for ; Mon, 19 Sep 2022 20:56:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229847AbiISU4x convert rfc822-to-8bit (ORCPT ); Mon, 19 Sep 2022 16:56:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229492AbiISU4u (ORCPT ); Mon, 19 Sep 2022 16:56:50 -0400 Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 884114BA4F for ; Mon, 19 Sep 2022 13:56:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 20A7E63BBD39; Mon, 19 Sep 2022 22:56:46 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CXropBphbfZn; Mon, 19 Sep 2022 22:56:45 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by lithops.sigma-star.at (Postfix) with ESMTP id 2412B63BBD41; Mon, 19 Sep 2022 22:56:45 +0200 (CEST) Received: from lithops.sigma-star.at ([127.0.0.1]) by localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6lDz_60MzvkD; Mon, 19 Sep 2022 22:56:45 +0200 (CEST) Received: from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130]) by lithops.sigma-star.at (Postfix) with ESMTP id EFA3763BBD39; Mon, 19 Sep 2022 22:56:44 +0200 (CEST) Date: Mon, 19 Sep 2022 22:56:44 +0200 (CEST) From: Richard Weinberger To: Randy Dunlap , davidgow Cc: anton ivanov , Johannes Berg , Nick Desaulniers , tglx , mingo , dave hansen , torvalds , Brendan Higgins , Daniel Latypov , linux-um , linux-kernel , kunit-dev@googlegroups.com, x86 Message-ID: <437983532.241061.1663621004742.JavaMail.zimbra@nod.at> In-Reply-To: <39e063ad-208d-f5f0-9807-eedcf0db1692@infradead.org> References: <20220823010830.2675419-1-davidgow@google.com> <39e063ad-208d-f5f0-9807-eedcf0db1692@infradead.org> Subject: Re: [PATCH] arch: um: Mark the stack non-executable to fix a binutils warning MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT X-Originating-IP: [195.201.40.130] X-Mailer: Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF97 (Linux)/8.8.12_GA_3809) Thread-Topic: arch: um: Mark the stack non-executable to fix a binutils warning Thread-Index: zdAqwB2k00Llj9CfHPRJhRE7IrjHTg== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ----- Ursprüngliche Mail ----- > Von: "Randy Dunlap" >> Link: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ffcf9c5700e49c0aee42dcba9a12ba21338e8136 >> Link: >> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=ba951afb99912da01a6e8434126b8fac7aa75107 >> Signed-off-by: David Gow > > Acked-by: Randy Dunlap # build-tested This patch causes a build error on one of my systems: /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: unrecognized option '--no-warn-rwx-segments' /usr/lib64/gcc/x86_64-suse-linux/7/../../../../x86_64-suse-linux/bin/ld: use the --help option for usage information collect2: error: ld returned 1 exit status Just like in commit ffcf9c5700e4 ("x86: link vdso and boot with -z noexecstack --no-warn-rwx-segments") you need to test for it. Thanks, //richard