From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Simon Derr <Simon.Derr@bull.net>,
Christoph Lameter <clameter@sgi.com>,
"Rohit, Seth" <rohit.seth@intel.com>
Subject: Re: [PATCH 01/05] mm fix __alloc_pages cpuset ALLOC_* flags
Date: Tue, 15 Nov 2005 19:52:20 +1100 [thread overview]
Message-ID: <4379A1C4.509@yahoo.com.au> (raw)
In-Reply-To: <20051114040329.13951.39891.sendpatchset@jackhammer.engr.sgi.com>
Paul Jackson wrote:
> Two changes to the setting of the ALLOC_CPUSET flag in
> mm/page_alloc.c:__alloc_pages()
>
> 1) A bug fix - the "ignoring mins" case should not be honoring
> ALLOC_CPUSET. This case of all cases, since it is handling a
> request that will free up more memory than is asked for (exiting
> tasks, e.g.) should be allowed to escape cpuset constraints
> when memory is tight.
>
> 2) A logic change to make it simpler. Honor cpusets even on
> GFP_ATOMIC (!wait) requests. With this, cpuset confinement
> applies to all requests except ALLOC_NO_WATERMARKS, so that
> in a subsequent cleanup patch, I can remove the ALLOC_CPUSET
> flag entirely. Since I don't know any real reason this
> logic has to be either way, I am choosing the path of the
> simplest code.
>
Hi,
I think #1 is OK, however I was under the impression that you
introduced the exception reverted in #2 due to seeing atomic
allocation failures?!
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Paul Jackson <pj@sgi.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Simon Derr <Simon.Derr@bull.net>,
Christoph Lameter <clameter@sgi.com>,
"Rohit, Seth" <rohit.seth@intel.com>
Subject: Re: [PATCH 01/05] mm fix __alloc_pages cpuset ALLOC_* flags
Date: Tue, 15 Nov 2005 19:52:20 +1100 [thread overview]
Message-ID: <4379A1C4.509@yahoo.com.au> (raw)
In-Reply-To: <20051114040329.13951.39891.sendpatchset@jackhammer.engr.sgi.com>
Paul Jackson wrote:
> Two changes to the setting of the ALLOC_CPUSET flag in
> mm/page_alloc.c:__alloc_pages()
>
> 1) A bug fix - the "ignoring mins" case should not be honoring
> ALLOC_CPUSET. This case of all cases, since it is handling a
> request that will free up more memory than is asked for (exiting
> tasks, e.g.) should be allowed to escape cpuset constraints
> when memory is tight.
>
> 2) A logic change to make it simpler. Honor cpusets even on
> GFP_ATOMIC (!wait) requests. With this, cpuset confinement
> applies to all requests except ALLOC_NO_WATERMARKS, so that
> in a subsequent cleanup patch, I can remove the ALLOC_CPUSET
> flag entirely. Since I don't know any real reason this
> logic has to be either way, I am choosing the path of the
> simplest code.
>
Hi,
I think #1 is OK, however I was under the impression that you
introduced the exception reverted in #2 due to seeing atomic
allocation failures?!
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-15 8:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 4:03 [PATCH 01/05] mm fix __alloc_pages cpuset ALLOC_* flags Paul Jackson
2005-11-14 4:03 ` Paul Jackson
2005-11-14 4:03 ` [PATCH 02/05] mm simplify " Paul Jackson
2005-11-14 4:03 ` Paul Jackson
2005-11-14 4:03 ` [PATCH 03/05] mm rationalize __alloc_pages ALLOC_* flag names Paul Jackson
2005-11-14 4:03 ` Paul Jackson
2005-11-15 9:00 ` Nick Piggin
2005-11-15 9:00 ` Nick Piggin
2005-11-15 9:03 ` Andrew Morton
2005-11-15 9:03 ` Andrew Morton
2005-11-15 9:55 ` Nick Piggin
2005-11-15 9:55 ` Nick Piggin
2005-11-15 19:20 ` Paul Jackson
2005-11-15 19:20 ` Paul Jackson
2005-11-15 9:59 ` Arjan van de Ven
2005-11-15 9:59 ` Arjan van de Ven
2005-11-15 9:18 ` Paul Jackson
2005-11-15 9:18 ` Paul Jackson
2005-11-14 4:04 ` [PATCH 04/05] mm simplify __alloc_pages cpuset hardwall logic Paul Jackson
2005-11-14 4:04 ` Paul Jackson
2005-11-14 4:04 ` [PATCH 05/05] mm GFP_ATOMIC comment Paul Jackson
2005-11-14 4:04 ` Paul Jackson
2005-11-15 8:52 ` Nick Piggin [this message]
2005-11-15 8:52 ` [PATCH 01/05] mm fix __alloc_pages cpuset ALLOC_* flags Nick Piggin
2005-11-15 9:50 ` Paul Jackson
2005-11-15 9:50 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4379A1C4.509@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pj@sgi.com \
--cc=rohit.seth@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.