All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shailabh Nagar <nagar@watson.ibm.com>
To: Peter Chubb <peterc@gelato.unsw.edu.au>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Andi Kleen <ak@suse.de>
Subject: Re: [Patch 1/4] Delay accounting: Initialization
Date: Tue, 15 Nov 2005 20:48:29 -0500	[thread overview]
Message-ID: <437A8FED.3080508@watson.ibm.com> (raw)
In-Reply-To: <17274.34333.348600.111728@wombat.chubb.wattle.id.au>

Peter Chubb wrote:
>>>>>>"Andrew" == Andrew Morton <akpm@osdl.org> writes:
> 
> 
> Andrew> Shailabh Nagar <nagar@watson.ibm.com> wrote:
> 
>>> + *ts = sched_clock();
> 
> 
> Andrew> I'm not sure that it's kosher to use sched_clock() for
> Andrew> fine-grained timestamping like this.  Ingo had issues with it
> Andrew> last time this happened?
> 
> It wasn't Ingo, it was Andi Kleen...  for my Microstate Accounting
> patches, which do very similar things to Shailabh's patchsetm, but
> using /proc and a system call instead (following Solaris's lead)
> 

Were these the comments from Andi to which you refer:
	http://www.uwsg.indiana.edu/hypermail/linux/kernel/0503.1/1237.html

The objections to microstate overhead seemed to stem from the syscall
overhead, not use of sched_clock() per se.


Andi, Ingo,

Are there problems with using sched_clock()for timestamping if one is prepared
to live with them not necessarily being nanosecond accurate ? I'm trying to search
the archives etc. but if you can respond with any quick comments, that'd be very
helpful.


Thanks,
Shailabh


  reply	other threads:[~2005-11-16  1:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-15  4:35 [Patch 1/4] Delay accounting: Initialization Shailabh Nagar
2005-11-15  4:20 ` Andrew Morton
2005-11-15  6:49   ` Marcelo Tosatti
2005-11-15 15:19     ` Shailabh Nagar
2005-11-15 12:20       ` Marcelo Tosatti
2005-11-15 12:34         ` Marcelo Tosatti
2005-11-15 15:08   ` Shailabh Nagar
2005-11-16  1:06   ` Peter Chubb
2005-11-16  1:48     ` Shailabh Nagar [this message]
2005-11-16  1:50       ` Andi Kleen
2005-11-16  1:52       ` Peter Chubb
2005-11-15  4:25 ` Parag Warudkar
2005-11-15 22:29   ` Shailabh Nagar
2005-11-15 22:53     ` Parag Warudkar
2005-11-16  0:45       ` Shailabh Nagar
2005-11-16  2:41         ` Parag Warudkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437A8FED.3080508@watson.ibm.com \
    --to=nagar@watson.ibm.com \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterc@gelato.unsw.edu.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.