All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: linux-ide@vger.kernel.org
Subject: Re: ata_port->device[] question
Date: Wed, 16 Nov 2005 10:16:07 -0500	[thread overview]
Message-ID: <437B4D37.8040304@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0511151328070.28745@shark.he.net>

Randy.Dunlap wrote:
> libata-core.c, around line 1299, says:
> 
> static inline u8 ata_dev_knobble(const struct ata_port *ap)
> {
> 	return ((ap->cbl == ATA_CBL_SATA) && (!ata_id_is_sata(ap->device->id)));
> }
> 
> That's the same as this: (right?)
> 
> 	return ((ap->cbl == ATA_CBL_SATA) && (!ata_id_is_sata(ap->device[0]->id)));
> 	                                                                ~~~
> 
> and is this intentional?
> I.e., always using device[0] for this bridge check?

really it should be ap->device[0].id if I'm not mistaken

	Jeff




      parent reply	other threads:[~2005-11-16 15:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-15 21:33 ata_port->device[] question Randy.Dunlap
2005-11-16 15:13 ` Bartlomiej Zolnierkiewicz
2005-11-16 15:16 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=437B4D37.8040304@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.