From: Vince Busam <vbusam@google.com>
To: nfs@lists.sourceforge.net
Subject: Funny looking code in __rpc_purge_upcall
Date: Wed, 16 Nov 2005 16:53:46 -0800 [thread overview]
Message-ID: <437BD49A.5070509@google.com> (raw)
In __rpc_purge_upcall (net/sunrpc/rpc_pipe.c), the newer code to clean up the in_upcall
list looks bad. Shouldn't the first argument to list_entry() be rpci->in_upcall.next?
--- net/sunrpc/rpc_pipe.c.orig 2005-11-16 16:48:00.000000000 -0800
+++ net/sunrpc/rpc_pipe.c 2005-11-16 16:52:23.000000000 -0800
@@ -51,7 +51,7 @@ __rpc_purge_upcall(struct inode *inode,
rpci->ops->destroy_msg(msg);
}
while (!list_empty(&rpci->in_upcall)) {
- msg = list_entry(rpci->pipe.next, struct rpc_pipe_msg, list);
+ msg = list_entry(rpci->in_upcall.next, struct rpc_pipe_msg, list);
list_del_init(&msg->list);
msg->errno = err;
rpci->ops->destroy_msg(msg);
Vince
-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
Register for a JBoss Training Course. Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next reply other threads:[~2005-11-17 0:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 0:53 Vince Busam [this message]
2005-11-17 3:10 ` Funny looking code in __rpc_purge_upcall Trond Myklebust
2005-11-17 16:01 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437BD49A.5070509@google.com \
--to=vbusam@google.com \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.