When compiling over NFS using a 2.6.14 kernel, the following
spinlock recursion BUG popped:

nfs_update_inode: inode number mismatch
expected (0:16/0x1dee71a), got (0:16/0x100000000000000)
nfs_update_inode: inode number mismatch
expected (0:16/0x1dee71a), got (0:16/0x1dee719)
nfs_update_inode: inode number mismatch
expected (0:16/0x1dee71a), got (0:16/0x0)
nfs_update_inode: inode number mismatch
expected (0:16/0x1dee71a), got (0:16/0x1dee719)
BUG: spinlock recursion on CPU#0, bhc/22635 (Not tainted)
  lock: db7294e8, .magic: dead4ead, .owner: bhc/22635, .owner_cpu: 0
  [<c01f53b3>] spin_bug+0xa3/0xd7
  [<c01f551e>] _raw_spin_lock+0x68/0x6a
  [<f8db1151>] nfs_zap_caches+0x1a/0xaa [nfs]
  [<f8db2445>] nfs_update_inode+0x9f/0x618 [nfs]
  [<c033be8c>] _spin_unlock_irq+0x5/0x7
  [<f8db236b>] nfs_post_op_update_inode+0x2c/0x67 [nfs]
  [<f8dba716>] nfs3_proc_remove+0x9e/0xd7 [nfs]
  [<f8daed5a>] nfs_safe_remove+0x68/0xc4 [nfs]
  [<f8daee5e>] nfs_unlink+0xa8/0x10e [nfs]
  [<c017c8df>] vfs_unlink+0x19f/0x1a6
  [<c017c9a3>] sys_unlink+0xbd/0x13e
  [<c033cee2>] do_page_fault+0x262/0x650
  [<c016cb1d>] do_sync_read+0x0/0x116
  [<c01040a5>] syscall_call+0x7/0xb
Kernel panic - not syncing: bad locking
  [<c01250a8>] panic+0x45/0x1c5
  [<c01f53e7>] __spin_lock_debug+0x0/0xcf
  [<c01f551e>] _raw_spin_lock+0x68/0x6a
  [<f8db1151>] nfs_zap_caches+0x1a/0xaa [nfs]
  [<f8db2445>] nfs_update_inode+0x9f/0x618 [nfs]
  [<c033be8c>] _spin_unlock_irq+0x5/0x7
  [<f8db236b>] nfs_post_op_update_inode+0x2c/0x67 [nfs]
  [<f8dba716>] nfs3_proc_remove+0x9e/0xd7 [nfs]
  [<f8daed5a>] nfs_safe_remove+0x68/0xc4 [nfs]
  [<f8daee5e>] nfs_unlink+0xa8/0x10e [nfs]
  [<c017c8df>] vfs_unlink+0x19f/0x1a6
  [<c017c9a3>] sys_unlink+0xbd/0x13e
  [<c033cee2>] do_page_fault+0x262/0x650
  [<c016cb1d>] do_sync_read+0x0/0x116
  [<c01040a5>] syscall_call+0x7/0xb

The attached patch solve the problem by the problem by moving
the call to nfs_invalidate_inode() out of nfs_invalidate_inode().

Commments?

steved.