From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet
Date: Fri, 18 Nov 2005 17:11:51 +0300 [thread overview]
Message-ID: <437DE127.50507@ru.mvista.com> (raw)
In-Reply-To: <20051117140715.GC9753@logos.cnet>
Marcelo Tosatti wrote:
> On Wed, Nov 16, 2005 at 03:04:33PM +0300, Vitaly Bordug wrote:
>> This adds board-specific files needed to utilize fs_enet Ethernet driver
>> for MPC885ADS and MPC866ADS.
>>
>> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
>>
>
> Vitaly,
>
> It also sounds to me that mpc885_nonplatform_device_init()
> initialization suits board_init() time, instead of post-start_kernel()
> do_initcalls(). No?
>
>
>
Well, maybe, but it actually works and since this approach prevents messing up the
m8xx_setup.c with #ifdef hell, I prefer the additional initialization to be there.
If this is odd, I'll proceed with the right way of course.
--
Sincerely,
Vitaly
next prev parent reply other threads:[~2005-11-18 14:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-16 12:04 [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet Vitaly Bordug
2005-11-17 13:58 ` Marcelo Tosatti
2005-11-18 14:09 ` Vitaly Bordug
2005-11-18 9:08 ` Marcelo Tosatti
2005-11-23 2:40 ` Paul Mackerras
2005-11-23 9:11 ` Marcelo Tosatti
2005-11-23 16:05 ` Kumar Gala
2005-11-23 12:00 ` Marcelo Tosatti
2005-11-23 18:25 ` 'Aristeu Sergio Rozanski Filho'
2005-11-23 20:18 ` Dan Malek
2005-11-23 15:39 ` Marcelo Tosatti
2005-11-30 7:08 ` Kumar Gala
2005-12-01 12:17 ` Marcelo Tosatti
2005-12-01 14:15 ` Dan Malek
2005-12-01 15:13 ` Kumar Gala
2005-11-23 16:14 ` Vitaly Bordug
2005-11-17 14:07 ` Marcelo Tosatti
2005-11-18 14:11 ` Vitaly Bordug [this message]
2005-11-18 9:05 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2005-11-18 16:19 Vitaly Bordug
2005-11-23 8:34 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=437DE127.50507@ru.mvista.com \
--to=vbordug@ru.mvista.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.