All of lore.kernel.org
 help / color / mirror / Atom feed
From: Witold Rugowski <rugowski@nhw.pl>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] sound/oss/maestro3.c printk args concatenation
Date: Sun, 20 Nov 2005 10:57:40 +0000	[thread overview]
Message-ID: <438056A4.8000302@nhw.pl> (raw)
In-Reply-To: <437E8107.2000103@nhw.pl>

Nish Aravamudan wrote:
> Missing spaces?

Yes. But that was my first time ;-)) so - improved patch version follows:

--- linux-2.6.14.2/sound/oss/maestro3.c	Fri Nov 11 06:33:12 2005
+++ linux-2.6.14.2-wr/sound/oss/maestro3.c	Sun Nov 20 11:10:28 2005
@@ -2935,7 +2935,8 @@ static struct pci_driver m3_pci_driver  
 static int __init m3_init_module(void)
 {
-    printk(KERN_INFO PFX "version " DRIVER_VERSION " built at " __TIME__ " " __DATE__ "\n");
+    printk(KERN_INFO "%sversion %s built at %s %s\n", PFX, DRIVER_VERSION,
+                      __TIME__, __DATE__);
 
     if (register_reboot_notifier(&m3_reboot_nb)) {
         printk(KERN_WARNING PFX "reboot notifier registration failed\n");

-- 
Witold Rugowski
rugowski _at_ nhw.pl http://nhw.pl/blg/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-11-20 10:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-19  1:33 [KJ] [PATCH] sound/oss/maestro3.c printk args concatenation Witold Rugowski
2005-11-19  2:17 ` Nish Aravamudan
2005-11-20 10:57 ` Witold Rugowski [this message]
2005-11-20 16:57 ` Nish Aravamudan
2005-11-21 23:01 ` Håkon Løvdal
2005-11-21 23:11 ` Nish Aravamudan
2005-11-21 23:25 ` Witold Rugowski
2005-11-22 18:26 ` Nish Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438056A4.8000302@nhw.pl \
    --to=rugowski@nhw.pl \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.