From: Thomas Monjalon <thomas@monjalon.net>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Tyler Retzlaff <roretzla@linux.microsoft.com>,
dev@dpdk.org
Subject: Re: [PATCH] eal: add getline() function for Windows
Date: Thu, 12 Jun 2025 03:01:03 +0200 [thread overview]
Message-ID: <4381337.bcXerOTE6V@thomas> (raw)
In-Reply-To: <1746477607-14961-1-git-send-email-andremue@linux.microsoft.com>
05/05/2025 22:40, Andre Muezerie:
> Existing DPDK code uses getline(), which is a POSIX function and is
> not available in the Windows APIs.
>
> Instead of rewriting it or coming up with some other replacement, this
> patch makes use of the implementation provided by NetBSD to make it
> possible to compile code dependent on getline on Windows.
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
It has been approved by the techboard on May 28,
and the govboard on May 30,
so the patch is applied, thanks.
next prev parent reply other threads:[~2025-06-12 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 20:40 [PATCH] eal: add getline() function for Windows Andre Muezerie
2025-05-20 17:14 ` Stephen Hemminger
2025-05-21 0:35 ` Andre Muezerie
2025-05-21 7:00 ` Thomas Monjalon
2025-05-21 20:23 ` Andre Muezerie
2025-06-12 1:01 ` Thomas Monjalon [this message]
2025-06-12 14:42 ` Andre Muezerie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4381337.bcXerOTE6V@thomas \
--to=thomas@monjalon.net \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.