From: Patrick McHardy <kaber@trash.net>
To: Folkert van Heusden <folkert@vanheusden.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.6.14] bug in inet_connection_sock.c -> lowest port always skipped
Date: Mon, 21 Nov 2005 19:12:51 +0100 [thread overview]
Message-ID: <43820E23.2060303@trash.net> (raw)
In-Reply-To: <20051121180224.GY32512@vanheusden.com>
Folkert van Heusden wrote:
> There seems to be a small bug in inet_connection_sock.c: the lowest port
> set using sysctl (taken from 'sysctl_local_port_range') is always
> skipped in the first iteration.
> In inet_csk_get_port one can find this:
> if (hashinfo->port_rover < low)
> rover = low;
> else
> rover = hashinfo->port_rover;
> do {
> rover++;
> As you can see the first statement is a ++ causing the first port to
> always be skipped.
This has already been fixed three weeks ago by Stephen Hemminger's port
randomization patch.
next prev parent reply other threads:[~2005-11-21 18:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-21 18:02 [2.6.14] bug in inet_connection_sock.c -> lowest port always skipped Folkert van Heusden
2005-11-21 18:12 ` Patrick McHardy [this message]
2005-11-22 11:16 ` Folkert van Heusden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43820E23.2060303@trash.net \
--to=kaber@trash.net \
--cc=folkert@vanheusden.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.