From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: USB virt 2.6 split driver patch series Date: Tue, 22 Nov 2005 09:37:50 -0600 Message-ID: <43833B4E.8070502@us.ibm.com> References: <1132581661.31295.134.camel@localhost.localdomain> <5d7aca950511210641n23d79fduc2e462c3dcd07810@mail.gmail.com> <1132586050.31295.145.camel@localhost.localdomain> <5d7aca950511210727i741148efl71f025577680d994@mail.gmail.com> <1132587554.31295.154.camel@localhost.localdomain> <5d7aca950511210902j5002bbfdxe52b1a32517d6c8b@mail.gmail.com> <1132593451.31295.171.camel@localhost.localdomain> <5d7aca950511211759i63ed353al8f95ea411bbd49ff@mail.gmail.com> <5d7aca950511211800j9799a2dy3186ef4133213417@mail.gmail.com> <1132655069.5956.5.camel@localhost.localdomain> <20051122110710.GA29624@snarc.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20051122110710.GA29624@snarc.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Vincent Hanquez Cc: NAHieu , harry , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Vincent Hanquez wrote: >On Tue, Nov 22, 2005 at 10:24:29AM +0000, harry wrote: > > >>Also identifiers with two leading underscores are reserved by >>ANSI C for the C compiler implementation so I think it's not a good idea >>to use them. >> >> > >This rule is not valid in kernelspace, using 2 leading underscores is >common practice. > > Harry's right, it's not allowed by the C standard. FWIW, I don't think it's all that common to use underscores to denote functions as private when you can just mark them static. Regards, Anthony Liguori